Conversation
Adds a simple setup hook that would add any fetched Deno deps to the node_modules folder at the root source directory.
a2ab413 to
afe5236
Compare
|
Hi. I am interested in using Opendeck, and it is my understanding that the Deno framework has already been merged into main (according to what I saw in https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/by-name/de/deno/package.nix and https://search.nixos.org/packages?channel=unstable&show=deno&type=packages&query=deno, but feel free to correct me if I'm wrong). |
|
While Deno itself has already been in Nixpkgs for a while, the problem is that we do not have a reliable way to pre-download dependencies in the format that Deno expects. During the build process we don't have internet access so this needs to be done beforehand in a way that is stable. Unfortunately Deno's native caching abilities are very brittle and shouldn't be relied upon and we still need a better alternative, which is why this PR still cannot be merged at this moment. See #417591, #407434 (comment). |
|
Oh, I see. It seems here that the build support helper merge was reverted and everything, so I guess that would make it impossible for me to just try and use this PR as-is. |
I made a separate repo for the buildDenoPackage now, since I don't expect the new PR to ever get merged into nixpkgs due to nobody reviewing my code. |
This PR will remain as a DRAFT until the necessary Deno infrastructure has been merged, which would be separated out into another PR.
Until then, this PR is still buildable and testable, though please only review the changes pertaining to OpenDeck itself in this PR — any suggestions towards the Deno infrastructure should be directed to its own PR.
Note: If you are using a NVIDIA GPU on Linux, you should know that OpenDeck, like all Tauri applications, suffers from a WebkitGTK bug that either makes the window entirely black or makes the app crash entirely. This is an upstream bug. Setting
WEBKIT_DISABLE_DMABUF_RENDERER=1might resolve the issue, but your mileage will vary.Open questions:
Closes #356016
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.