Skip to content

teleport_15: 15.4.21 -> 15.4.22, teleport_16: 16.4.6 -> 16.4.8, teleport_17: init at 17.0.1#358048

Closed
techknowlogick wants to merge 3 commits intoNixOS:masterfrom
techknowlogick:teleport_16-bump
Closed

teleport_15: 15.4.21 -> 15.4.22, teleport_16: 16.4.6 -> 16.4.8, teleport_17: init at 17.0.1#358048
techknowlogick wants to merge 3 commits intoNixOS:masterfrom
techknowlogick:teleport_16-bump

Conversation

@techknowlogick
Copy link
Member

https://github.com/gravitational/teleport/releases/tag/v15.4.22
https://github.com/gravitational/teleport/releases/tag/v16.4.8
https://github.com/gravitational/teleport/releases/tag/v17.0.1

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@justinas justinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

Please make v17 the default as described. Afterwards, please also add an explicit test for v16 to nixos/tests/teleport.nix. v17 will be tested automatically, since the test has a case with the default pkgs.teleport.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Nov 22, 2024
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog This PR adds or changes release notes labels Nov 23, 2024
@techknowlogick
Copy link
Member Author

Thanks @justinas, I've adjusted this PR based on your feedback :)

@techknowlogick techknowlogick added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Nov 25, 2024
@techknowlogick techknowlogick added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Nov 26, 2024
@wegank wegank removed 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Nov 26, 2024
@FliegendeWurst FliegendeWurst added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 5, 2024
@kaleocheng
Copy link
Contributor

kaleocheng commented Dec 16, 2024

@techknowlogick seems this PR is kind of ready but just need minor change for the merge conflict. could you rebase it?

Edit: I’d also suggest splitting this PR into multiple smaller PRs—one for the 15/16 changes and another for the 17 initialization maybe. so we can easily backport the 15/16 changes to 24.11.

@JuliusFreudenberger
Copy link
Contributor

@techknowlogick, do you want to continue working on this PR? Otherwise I am willing to take on the updates of teleport{15,16} and the init of teleport17 in separate PRs as suggested.

@justinas
Copy link
Member

@techknowlogick, do you want to continue working on this PR? Otherwise I am willing to take on the updates of teleport{15,16} and the init of teleport17 in separate PRs as suggested.

I would recommend you to go ahead with making your PR as this PR has been hanging for a bit already, and Teleport moves quickly. 🙂

@techknowlogick
Copy link
Member Author

Oh, yes please. Sorry for this one dropping off my radar. If you do create them, could you ping me as well since sometimes the automatic PR review requests sometimes don't work for this package

@JuliusFreudenberger
Copy link
Contributor

I gave it a shot bumping teleport 15 and 16 in #376749, but faced problems with version 16. Maybe you can have a look there.

@techknowlogick
Copy link
Member Author

Closing this due to conflicts, and alternative PRs.

@techknowlogick techknowlogick deleted the teleport_16-bump branch January 25, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants