teleport_15: 15.4.21 -> 15.4.22, teleport_16: 16.4.6 -> 16.4.8, teleport_17: init at 17.0.1#358048
teleport_15: 15.4.21 -> 15.4.22, teleport_16: 16.4.6 -> 16.4.8, teleport_17: init at 17.0.1#358048techknowlogick wants to merge 3 commits intoNixOS:masterfrom
Conversation
9b8adef to
425e8ed
Compare
justinas
left a comment
There was a problem hiding this comment.
Thanks for the PR.
Please make v17 the default as described. Afterwards, please also add an explicit test for v16 to nixos/tests/teleport.nix. v17 will be tested automatically, since the test has a case with the default pkgs.teleport.
54fd3ef to
99628a0
Compare
|
Thanks @justinas, I've adjusted this PR based on your feedback :) |
3be6924 to
e49667d
Compare
e49667d to
9fc9806
Compare
|
@techknowlogick seems this PR is kind of ready but just need minor change for the merge conflict. could you rebase it? Edit: I’d also suggest splitting this PR into multiple smaller PRs—one for the 15/16 changes and another for the 17 initialization maybe. so we can easily backport the 15/16 changes to 24.11. |
|
@techknowlogick, do you want to continue working on this PR? Otherwise I am willing to take on the updates of teleport{15,16} and the init of teleport17 in separate PRs as suggested. |
I would recommend you to go ahead with making your PR as this PR has been hanging for a bit already, and Teleport moves quickly. 🙂 |
|
Oh, yes please. Sorry for this one dropping off my radar. If you do create them, could you ping me as well since sometimes the automatic PR review requests sometimes don't work for this package |
|
I gave it a shot bumping teleport 15 and 16 in #376749, but faced problems with version 16. Maybe you can have a look there. |
|
Closing this due to conflicts, and alternative PRs. |
https://github.com/gravitational/teleport/releases/tag/v15.4.22
https://github.com/gravitational/teleport/releases/tag/v16.4.8
https://github.com/gravitational/teleport/releases/tag/v17.0.1
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.