php84: 8.4.0RC4 -> 8.4.1

[pan93412]

• php84: 8.4.0RC4 -> 8.4.1
• php-packages: remove the merged soap patch (ext/soap: fix make check being invoked in ext/soap php/php-src#16733)

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[pan93412]

Diff LGTM - But I would wait for the official announcement before merging this, so we make sure that upstream hasn't rebuilt the official source archive.

https://www.php.net/index.php#2024-11-21-4. It has been announced today. Note that I still prefer to wait the test passed before merging this, since I have only tested it on macOS.

[drupol]

Oh boy... sorry about this :)

Waiting for tests to be done goes without saying !

I'll merge this as soon as this is green.

[drupol]

@ofborg build php84

[piotrkwiecinski]

This should also be backported to 24.11

[drupol]

Looks like there's a build issue:

PASS Bug #80763 (msgfmt_format() does not accept DateTime references) [tests/bug80763.phpt] 
gcc: warning:  -DZEND_COMPILE_DL_EXT=1: linker input file unused because linking not done
gcc: error:  -DZEND_COMPILE_DL_EXT=1: linker input file not found: No such file or directory
make: *** [Makefile:206: apc.lo] Error 1
checking pkg-config is at least version 0.9.0... yes
error: builder for '/nix/store/dh7rkk42hyjb48c41yimyyr6cy0y8x1x-php-apcu-5.1.23.drv' failed with exit code 2;
       last 10 log lines:
       > configure: creating ./config.status
       > config.status: creating config.h
       > Running phase: buildPhase
       > build flags: SHELL=/nix/store/0irlcqx2n3qm6b1pc9rsd2i8qpvcccaj-bash-5.2p37/bin/bash EXTENSION_DIR=\$\(out\)/lib/php/extensions phpincludedir=\$\(dev\)/include
       > /nix/store/0irlcqx2n3qm6b1pc9rsd2i8qpvcccaj-bash-5.2p37/bin/bash /build/source/libtool --tag=CC --mode=compile gcc -I. -I/build/source -I/nix/store/lkcbqnwg5sh196yjiry3h6nwnvbwyqgf-php-8.4.1-dev/include/php -I/nix/store/lkcbqnwg5sh196yjiry3h6nwnvbwyqgf-php-8.4.1-dev/include/php/main -I/nix/store/lkcbqnwg5sh196yjiry3h6nwnvbwyqgf-php-8.4.1-dev/include/php/TSRM -I/nix/store/lkcbqnwg5sh196yjiry3h6nwnvbwyqgf-php-8.4.1-dev/include/php/Zend -I/nix/store/lkcbqnwg5sh196yjiry3h6nwnvbwyqgf-php-8.4.1-dev/include/php/ext -I/nix/store/lkcbqnwg5sh196yjiry3h6nwnvbwyqgf-php-8.4.1-dev/include/php/ext/date/lib  -DHAVE_CONFIG_H  -g -O2 -D_GNU_SOURCE   \ -DZEND_COMPILE_DL_EXT=1 -c /build/source/apc.c -o apc.lo  -MMD -MF apc.dep -MT apc.lo
       > mkdir .libs
       >  gcc -I. -I/build/source -I/nix/store/lkcbqnwg5sh196yjiry3h6nwnvbwyqgf-php-8.4.1-dev/include/php -I/nix/store/lkcbqnwg5sh196yjiry3h6nwnvbwyqgf-php-8.4.1-dev/include/php/main -I/nix/store/lkcbqnwg5sh196yjiry3h6nwnvbwyqgf-php-8.4.1-dev/include/php/TSRM -I/nix/store/lkcbqnwg5sh196yjiry3h6nwnvbwyqgf-php-8.4.1-dev/include/php/Zend -I/nix/store/lkcbqnwg5sh196yjiry3h6nwnvbwyqgf-php-8.4.1-dev/include/php/ext -I/nix/store/lkcbqnwg5sh196yjiry3h6nwnvbwyqgf-php-8.4.1-dev/include/php/ext/date/lib -DHAVE_CONFIG_H -g -O2 -D_GNU_SOURCE " -DZEND_COMPILE_DL_EXT=1" -c /build/source/apc.c -MMD -MF apc.dep -MT apc.lo  -fPIC -DPIC -o .libs/apc.o
       > gcc: warning:  -DZEND_COMPILE_DL_EXT=1: linker input file unused because linking not done
       > gcc: error:  -DZEND_COMPILE_DL_EXT=1: linker input file not found: No such file or directory
       > make: *** [Makefile:206: apc.lo] Error 1
       For full logs, run 'nix-store -l /nix/store/dh7rkk42hyjb48c41yimyyr6cy0y8x1x-php-apcu-5.1.23.drv'.

[pan93412]

Looks like there's a build issue:

PASS Bug #80763 (msgfmt_format() does not accept DateTime references) [tests/bug80763.phpt] 

gcc: warning:  -DZEND_COMPILE_DL_EXT=1: linker input file unused because linking not done

gcc: error:  -DZEND_COMPILE_DL_EXT=1: linker input file not found: No such file or directory

make: *** [Makefile:206: apc.lo] Error 1

checking pkg-config is at least version 0.9.0... yes

error: builder for '/nix/store/dh7rkk42hyjb48c41yimyyr6cy0y8x1x-php-apcu-5.1.23.drv' failed with exit code 2;

       last 10 log lines:

       > configure: creating ./config.status

       > config.status: creating config.h

       > Running phase: buildPhase

       > build flags: SHELL=/nix/store/0irlcqx2n3qm6b1pc9rsd2i8qpvcccaj-bash-5.2p37/bin/bash EXTENSION_DIR=\$\(out\)/lib/php/extensions phpincludedir=\$\(dev\)/include

       > /nix/store/0irlcqx2n3qm6b1pc9rsd2i8qpvcccaj-bash-5.2p37/bin/bash /build/source/libtool --tag=CC --mode=compile gcc -I. -I/build/source -I/nix/store/lkcbqnwg5sh196yjiry3h6nwnvbwyqgf-php-8.4.1-dev/include/php -I/nix/store/lkcbqnwg5sh196yjiry3h6nwnvbwyqgf-php-8.4.1-dev/include/php/main -I/nix/store/lkcbqnwg5sh196yjiry3h6nwnvbwyqgf-php-8.4.1-dev/include/php/TSRM -I/nix/store/lkcbqnwg5sh196yjiry3h6nwnvbwyqgf-php-8.4.1-dev/include/php/Zend -I/nix/store/lkcbqnwg5sh196yjiry3h6nwnvbwyqgf-php-8.4.1-dev/include/php/ext -I/nix/store/lkcbqnwg5sh196yjiry3h6nwnvbwyqgf-php-8.4.1-dev/include/php/ext/date/lib  -DHAVE_CONFIG_H  -g -O2 -D_GNU_SOURCE   \ -DZEND_COMPILE_DL_EXT=1 -c /build/source/apc.c -o apc.lo  -MMD -MF apc.dep -MT apc.lo

       > mkdir .libs

       >  gcc -I. -I/build/source -I/nix/store/lkcbqnwg5sh196yjiry3h6nwnvbwyqgf-php-8.4.1-dev/include/php -I/nix/store/lkcbqnwg5sh196yjiry3h6nwnvbwyqgf-php-8.4.1-dev/include/php/main -I/nix/store/lkcbqnwg5sh196yjiry3h6nwnvbwyqgf-php-8.4.1-dev/include/php/TSRM -I/nix/store/lkcbqnwg5sh196yjiry3h6nwnvbwyqgf-php-8.4.1-dev/include/php/Zend -I/nix/store/lkcbqnwg5sh196yjiry3h6nwnvbwyqgf-php-8.4.1-dev/include/php/ext -I/nix/store/lkcbqnwg5sh196yjiry3h6nwnvbwyqgf-php-8.4.1-dev/include/php/ext/date/lib -DHAVE_CONFIG_H -g -O2 -D_GNU_SOURCE " -DZEND_COMPILE_DL_EXT=1" -c /build/source/apc.c -MMD -MF apc.dep -MT apc.lo  -fPIC -DPIC -o .libs/apc.o

       > gcc: warning:  -DZEND_COMPILE_DL_EXT=1: linker input file unused because linking not done

       > gcc: error:  -DZEND_COMPILE_DL_EXT=1: linker input file not found: No such file or directory

       > make: *** [Makefile:206: apc.lo] Error 1

       For full logs, run 'nix-store -l /nix/store/dh7rkk42hyjb48c41yimyyr6cy0y8x1x-php-apcu-5.1.23.drv'.

I also encountered this issue on PHP 8.4.0RC3. Not sure why though.

[drupol]

Is this issue happening on RC4 too ?

[piotrkwiecinski]

There is new tag for https://github.com/krakjoe/apcu/releases/tag/v5.1.24 maybe we need to bump it too

[piotrkwiecinski]

I'll PR it

[Ma27]

@piotrkwiecinski Eh, I already prepared it while reviewing this PR.
Would push the update here and merge then.

[Ma27]

With the commit I just pushed, all tests in nixos/tests/php pass for me with 8.4.

[drupol]

Cool! Let's first merge the apcu PR, then this PR.

[Ma27]

@drupol I just pushed it into this PR, I didn't see a reason to split it off :)

[drupol]

Oh ! I haven't see it :) all good then !

[github-actions]

Successfully created backport PR for release-24.11:

• [Backport release-24.11] php84: 8.4.0RC4 -> 8.4.1 #358128