Skip to content

tinymist: 0.12.0 -> 0.12.4#357498

Merged
drupol merged 1 commit intoNixOS:masterfrom
GaetanLepage:tinymist
Nov 25, 2024
Merged

tinymist: 0.12.0 -> 0.12.4#357498
drupol merged 1 commit intoNixOS:masterfrom
GaetanLepage:tinymist

Conversation

@GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Nov 20, 2024 •
edited
Loading

Things done

Changelog: https://github.com/Myriad-Dreamin/tinymist/blob/refs/tags/v0.12.4/CHANGELOG.md

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: vscode A free and versatile code editor that supports almost every major programming language. label Nov 20, 2024
@GaetanLepage GaetanLepage requested review from LamprosPitsillos and drupol and removed request for LamprosPitsillos November 20, 2024 08:14
drupol
drupol reviewed Nov 20, 2024
View reviewed changes
Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite a few changes there, what happened?

@GaetanLepage
Copy link
Contributor Author

GaetanLepage commented Nov 20, 2024

Quite a few changes there, what happened?

  • The darwin refactor now automatically propagates the sdk things and we don't have to manually add them to buildInputs
  • The recently added fetchCargoVendor allows us to get rid of our vendored Cargo.lock.

drupol
drupol approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice!

@GaetanLepage
Copy link
Contributor Author

GaetanLepage commented Nov 20, 2024

unfortunately it doesn't build (2 failing tests). Let me report them upstream.

@GaetanLepage GaetanLepage mentioned this pull request Nov 20, 2024
Closed
@GaetanLepage
Copy link
Contributor Author

GaetanLepage commented Nov 20, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 357498

x86_64-linux

❌ 3 packages failed to build:
  • tinymist
  • vimPlugins.typst-preview-nvim
  • vscode-extensions.myriad-dreamin.tinymist

aarch64-linux

❌ 3 packages failed to build:
  • tinymist
  • vimPlugins.typst-preview-nvim
  • vscode-extensions.myriad-dreamin.tinymist

x86_64-darwin

❌ 3 packages failed to build:
  • tinymist
  • vimPlugins.typst-preview-nvim
  • vscode-extensions.myriad-dreamin.tinymist

aarch64-darwin

❌ 3 packages failed to build:
  • tinymist
  • vimPlugins.typst-preview-nvim
  • vscode-extensions.myriad-dreamin.tinymist

@drupol
Copy link
Contributor

drupol commented Nov 20, 2024

Oops

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 20, 2024
@GaetanLepage GaetanLepage marked this pull request as draft November 20, 2024 14:07
@ofborg ofborg bot requested a review from drupol November 21, 2024 02:38
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Nov 21, 2024
@GaetanLepage GaetanLepage changed the title tinymist: 0.12.0 -> 0.12.2 tinymist: 0.12.0 -> 0.12.4 Nov 23, 2024
@GaetanLepage
Copy link
Contributor Author

GaetanLepage commented Nov 24, 2024

Should we just skip all the flaky tests ?

@drupol
Copy link
Contributor

drupol commented Nov 25, 2024 •
edited
Loading

Yes... We should also report them upstream...

@GaetanLepage
Copy link
Contributor Author

GaetanLepage commented Nov 25, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 357498

x86_64-linux

✅ 3 packages built:
  • tinymist
  • vimPlugins.typst-preview-nvim
  • vscode-extensions.myriad-dreamin.tinymist

aarch64-linux

✅ 3 packages built:
  • tinymist
  • vimPlugins.typst-preview-nvim
  • vscode-extensions.myriad-dreamin.tinymist

x86_64-darwin

✅ 3 packages built:
  • tinymist
  • vimPlugins.typst-preview-nvim
  • vscode-extensions.myriad-dreamin.tinymist

aarch64-darwin

✅ 3 packages built:
  • tinymist
  • vimPlugins.typst-preview-nvim
  • vscode-extensions.myriad-dreamin.tinymist

@GaetanLepage GaetanLepage marked this pull request as ready for review November 25, 2024 12:40
@drupol drupol merged commit 1b5d0bc into NixOS:master Nov 25, 2024
@GaetanLepage GaetanLepage deleted the tinymist branch November 25, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drupol drupol drupol approved these changes

@LamprosPitsillos LamprosPitsillos Awaiting requested review from LamprosPitsillos

Assignees

No one assigned

Labels

6.topic: vscode A free and versatile code editor that supports almost every major programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GaetanLepage @drupol @wegank