Skip to content

rustPlatform.fetchCargoVendor: retry fetching tarballs #357262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mic92 merged 1 commit into from
Nov 19, 2024
Merged

rustPlatform.fetchCargoVendor: retry fetching tarballs #357262

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion pkgs/build-support/rust/fetch-cargo-vendor-util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
from typing import Any, TypedDict, cast

import requests
from requests.adapters import HTTPAdapter, Retry

eprint = functools.partial(print, file=sys.stderr)

Expand All @@ -21,8 +22,17 @@ def load_toml(path: Path) -> dict[str, Any]:


def download_file_with_checksum(url: str, destination_path: Path) -> str:
retries = Retry(
total=5,
backoff_factor=0.5,
status_forcelist=[500, 502, 503, 504]
)
session = requests.Session()
session.mount('http://', HTTPAdapter(max_retries=retries))
session.mount('https://', HTTPAdapter(max_retries=retries))

sha256_hash = hashlib.sha256()
with requests.get(url, stream=True) as response:
with session.get(url, stream=True) as response:

@JohnRTitor JohnRTitor Nov 19, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked the solution from the other PR, was pretty straightforward

But I guess this is more resilent

if not response.ok:
raise Exception(f"Failed to fetch file from {url}. Status code: {response.status_code}")
with open(destination_path, "wb") as file:
Expand Down