Skip to content

tuxguitar: fix start script#357246

Merged
Aleksanaa merged 4 commits intoNixOS:masterfrom
c31io:fix-tuxguitar-start-script
Nov 21, 2024
Merged

tuxguitar: fix start script#357246
Aleksanaa merged 4 commits intoNixOS:masterfrom
c31io:fix-tuxguitar-start-script

Conversation

@c31io
Copy link
Contributor

@c31io c31io commented Nov 19, 2024

  1. Fix tuxguitar fails to start #227206: The package now uses which java in the startup script, so we need which as build input and java in $PATH.
  2. Add warpGAppsHook to run in KDE.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12.first-time contribution This PR is the author's first one; please be gentle! label Nov 19, 2024
Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dontWrapGApps = true should also be set to avoid double wrapping the binary. See https://nixos.org/manual/nixpkgs/stable/#ssec-gnome-common-issues-double-wrapped

And welcome to Nixpkgs!

@c31io
Copy link
Contributor Author

c31io commented Nov 19, 2024

Thanks for the suggestions😊
Took me a while to figure out that I need to put warpProgram in postFixup to hook GSettings schemas.

c31io and others added 2 commits November 20, 2024 01:12
Co-authored-by: seth <getchoo@tuta.io>
@getchoo getchoo added the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 20, 2024
@ofborg ofborg bot requested a review from ardumont November 20, 2024 09:38
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Nov 20, 2024
@Aleksanaa Aleksanaa merged commit 17a9653 into NixOS:master Nov 21, 2024
@github-actions
Copy link
Contributor

Successfully created backport PR for release-24.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tuxguitar fails to start

4 participants