nixStatic: mark as broken on darwin#357185
Merged
fricklerhandwerk merged 1 commit intoNixOS:masterfrom Nov 19, 2024
Merged
Conversation
nix-owners
bot
requested review from
Ericson2314,
RaitoBezarius,
edolstra,
fricklerhandwerk,
roberth and
tomberek
tomberek
approved these changes
Nov 19, 2024
emilazy
added a commit
to emilazy/nixpkgs
that referenced
this pull request
Nov 19, 2024
This is no longer necessary now that `libarchive` has been fixed. This reverts commit 0705964.
github-actions bot
pushed a commit
that referenced
this pull request
Nov 19, 2024
(cherry picked from commit 0705964)
Contributor
|
Successfully created backport PR for |
1 task
vcunat
pushed a commit
that referenced
this pull request
Nov 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
Context: #356983 (comment)
It was broken for a while and requires more fixes in the macOS nixpkgs static overlay that might take a while to settle in.
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.