k3s: use nurl instead of nix-prefetch in update script #356772
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
6.topic: k3s
superherointj
approved these changes
Nov 17, 2024
ofborg
bot
added
10.rebuild-darwin: 0
The changes introduced with NixOS#354367 lead currently to an evaluation error when prefetching vendored go dependencies with `nix-prefetch`. Although this is probably a bug in `nix-prefetch`, I prefer to use `nurl` instead as it does the same thing, seems better maintained and doesn't block k3s updates even longer.
rorosen
force-pushed
the
k3s-update-script-nurl
branch
from
d67ea4d to
e2048ac
Compare
superherointj
approved these changes
Nov 18, 2024
wrmilling
approved these changes
Nov 18, 2024
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes introduced with #354367 lead currently to an evaluation error when prefetching vendored go dependencies with
nix-prefetch. Although this is probably a bug innix-prefetchthat could get fixed, I prefer to usenurlinstead as it does the same thing, seems better maintained and doesn't block k3s updates even longer.You will find comments with similar issues in #354367.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)@NixOS/k3s
Add a 👍 reaction to pull requests you find important.