Skip to content

bambu-studio: 01.09.07.52 > 01.10.01.50#356673

Merged
emilazy merged 2 commits intoNixOS:masterfrom
liberodark:bambu_1.10.1
Nov 23, 2024
Merged

bambu-studio: 01.09.07.52 > 01.10.01.50#356673
emilazy merged 2 commits intoNixOS:masterfrom
liberodark:bambu_1.10.1

Conversation

@liberodark
Copy link
Contributor

@liberodark liberodark commented Nov 17, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested review from dsluijk and zhaofengli November 17, 2024 19:53
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Nov 17, 2024
@dsluijk
Copy link
Member

dsluijk commented Nov 18, 2024

@ofborg build bambu-studio

@dsluijk
Copy link
Member

dsluijk commented Nov 18, 2024

The new version seems to break the building, so this needs to be fixed first. Please check this PR against your fork, which should resolve these issues. After that I believe this can be merged.

@liberodark
Copy link
Contributor Author

@ofborg build bambu-studio

@liberodark liberodark force-pushed the bambu_1.10.1 branch 2 times, most recently from 4e58176 to e4f62c5 Compare November 20, 2024 10:28
Copy link
Member

@dsluijk dsluijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch is still referenced in the derivation, please remove it. Take a look again at my PR, it's correct there.

@dsluijk
Copy link
Member

dsluijk commented Nov 20, 2024

@ofborg build bambu-studio

@ofborg ofborg bot requested a review from dsluijk November 21, 2024 05:06
@ofborg ofborg bot removed the 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. label Nov 21, 2024
@pinpox
Copy link
Member

pinpox commented Nov 23, 2024

@ofborg build orca-slicer

@liberodark
Copy link
Contributor Author

Hi,
Also 24.11 backport is needed. if is possible.

Best Regards

@emilazy emilazy merged commit 0a92232 into NixOS:master Nov 23, 2024
@github-actions
Copy link
Contributor

Successfully created backport PR for release-24.11:

@cameronraysmith cameronraysmith mentioned this pull request May 22, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants