Merged
Conversation
Member
Author
|
Member
Author
|
@toonn Could you review? |
kirillrdy
reviewed
Dec 2, 2024
Member
|
@kachick similar comment about commit message |
Member
Author
|
Thanks for reviewing! I have updated with reviewed points except for squashing the commits. Because I don't have confidence that including refactoring changes in the version up commit will be better or not. Please tell me if it is required. |
Member
|
squashing is not required, separate commits are fine, lets wait for ofborg to finish |
Member
|
@ofborg eval |
Member
Author
|
Failed |
https://github.com/NixOS/nixpkgs/pull/356336/files#r1865416515 Co-authored-by: kirillrdy <kirillrdy@gmail.com>
Member
|
7.15 is out ! |
Member
Author
|
Thank you for merging...! 😂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: xwmx/nb@7.14.4...7.14.6
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.