Skip to content

nb: 7.14.4 -> 7.14.6#356336

Merged
kirillrdy merged 2 commits intoNixOS:masterfrom
kachick:update-nb
Dec 4, 2024
Merged

nb: 7.14.4 -> 7.14.6#356336
kirillrdy merged 2 commits intoNixOS:masterfrom
kachick:update-nb

Conversation

@kachick
Copy link
Member

@kachick kachick commented Nov 16, 2024

Changes: xwmx/nb@7.14.4...7.14.6

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@kachick
Copy link
Member Author

kachick commented Nov 16, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 356336


x86_64-linux

✅ 1 package built:
  • nb

x86_64-darwin

✅ 1 package built:
  • nb

aarch64-darwin

✅ 1 package built:
  • nb

@kachick kachick requested a review from toonn November 16, 2024 03:33
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Nov 16, 2024
@kachick
Copy link
Member Author

kachick commented Dec 1, 2024

@toonn Could you review?

@kirillrdy
Copy link
Member

@kachick similar comment about commit message

@kachick kachick marked this pull request as draft December 2, 2024 08:29
@github-actions github-actions bot removed 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 2, 2024
@kachick
Copy link
Member Author

kachick commented Dec 2, 2024

Thanks for reviewing!

I have updated with reviewed points except for squashing the commits. Because I don't have confidence that including refactoring changes in the version up commit will be better or not. Please tell me if it is required.

@kachick kachick marked this pull request as ready for review December 2, 2024 08:46
@kirillrdy
Copy link
Member

squashing is not required, separate commits are fine, lets wait for ofborg to finish

@kirillrdy
Copy link
Member

@ofborg eval

@kachick
Copy link
Member Author

kachick commented Dec 4, 2024

Failed ofborg-eval-lib-tests — nix-build --arg pkgs import ./. {} ./lib/tests/release.nix from #354738, I'll rebase to avoid it.

@ofborg ofborg bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 4, 2024
@kirillrdy kirillrdy merged commit b305243 into NixOS:master Dec 4, 2024
@kirillrdy
Copy link
Member

7.15 is out !

@kachick
Copy link
Member Author

kachick commented Dec 5, 2024

Thank you for merging...! 😂

@kachick kachick deleted the update-nb branch December 5, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants