treewide: remove some unused shell scripts / hooks#356254
Merged
emilazy merged 8 commits intoNixOS:masterfrom Nov 16, 2024
Merged
treewide: remove some unused shell scripts / hooks#356254emilazy merged 8 commits intoNixOS:masterfrom
emilazy merged 8 commits intoNixOS:masterfrom
Conversation
github-actions
bot
added
6.topic: qt/kde
nix-owners
bot
requested review from
K900,
NickCao,
SuperSandro2000,
emilazy,
reckenrode,
toonn and
ttuegel
Contributor
|
Ack on kdoctools |
emilazy
approved these changes
Nov 16, 2024
Member
emilazy
left a comment
emilazy
left a comment
There was a problem hiding this comment.
Darwin hook is unreferenced so not actually doing anything. If we need it for static builds it’s probably best to merge libcharset.a into libiconv.a instead.
Member
|
Oh, and we literally already do it :) Thanks for the thorough investigation work, this looks good. |
Contributor
|
Successfully created backport PR for |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found those while looking through shell scripts in #353490 for a while.
None of them are in use anymore.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.