Skip to content

plausible: 2.0.0 -> 2.1.4#356221

Merged
NetaliDev merged 1 commit intoNixOS:masterfrom
xanderio:plausible-2.1.0
Dec 1, 2024
Merged

plausible: 2.0.0 -> 2.1.4#356221
NetaliDev merged 1 commit intoNixOS:masterfrom
xanderio:plausible-2.1.0

Conversation

@xanderio
Copy link
Contributor

@xanderio xanderio commented Nov 15, 2024

Changelog: https://github.com/plausible/analytics/blob/v2.1.4/CHANGELOG.md

This upgrade was quite the undertaking, the major source of headaches was that plausible now has a dependency that makes use of rustler, tooling to call rust from elixir.

As the newer plausible version drop support for admin user reaction via env var in favour of a first install wizard, this can be backported to stable. This first install wizard is also the reason why the nixos test was reduces, as this new installed is based on phoenix live views, we can simply interact with it using curl and grep :/

I'm yet to deploy this onto a production installation of plausible, but looking at the web UI in a simple test installation everything look fine.

Closes: #314768

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Nov 15, 2024
@xanderio xanderio force-pushed the plausible-2.1.0 branch 2 times, most recently from c130667 to 53a87e0 Compare November 15, 2024 18:18
@xanderio
Copy link
Contributor Author

Result of nixpkgs-review pr 356221 run on x86_64-linux 1

1 package blacklisted:
  • nixos-install-tools
1 package built:
  • plausible

@ofborg ofborg bot requested a review from blitz November 23, 2024 06:32
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Nov 23, 2024
Copy link
Member

@NetaliDev NetaliDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but in my opinion, this should be split into multiple commits: one commit for the package update, one for package reformatting, one for the update script refactoring, one for the module changes and one for the test changes.

@xanderio
Copy link
Contributor Author

LGTM, but in my opinion, this should be split into multiple commits: one commit for the package update, one for package reformatting, one for the update script refactoring, one for the module changes and one for the test changes.

I've thought about this, and I would like to keep it as one commit as otherwise we have one commit (package update) where the tests fail. This isn't that great when it comes to bisecting things.

@xanderio xanderio added the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 25, 2024
@xanderio
Copy link
Contributor Author

I've deployed this successfully.

@NetaliDev NetaliDev merged commit d3ba34c into NixOS:master Dec 1, 2024
@xanderio xanderio deleted the plausible-2.1.0 branch December 1, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update request: plausible: 2.0.0 → 2.1.0

3 participants