Conversation
c130667 to
53a87e0
Compare
53a87e0 to
d74a185
Compare
|
Result of 1 package blacklisted:
1 package built:
|
d74a185 to
e8c9fa5
Compare
NetaliDev
left a comment
There was a problem hiding this comment.
LGTM, but in my opinion, this should be split into multiple commits: one commit for the package update, one for package reformatting, one for the update script refactoring, one for the module changes and one for the test changes.
I've thought about this, and I would like to keep it as one commit as otherwise we have one commit (package update) where the tests fail. This isn't that great when it comes to bisecting things. |
|
I've deployed this successfully. |
Changelog: https://github.com/plausible/analytics/blob/v2.1.4/CHANGELOG.md
This upgrade was quite the undertaking, the major source of headaches was that plausible now has a dependency that makes use of rustler, tooling to call rust from elixir.
As the newer plausible version drop support for admin user reaction via env var in favour of a first install wizard, this can be backported to stable. This first install wizard is also the reason why the nixos test was reduces, as this new installed is based on phoenix live views, we can simply interact with it using
curlandgrep:/I'm yet to deploy this onto a production installation of plausible, but looking at the web UI in a simple test installation everything look fine.
Closes: #314768
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.