python312Packages.captum: init at 0.7.0 #356087
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
6.topic: python
ofborg
bot
added
8.has: package (new)
drupol
force-pushed
the
push-wnmlnxmlxxzn
branch
2 times, most recently
from
0d692ca to
4c8a6cb
Compare
GaetanLepage
requested changes
Nov 17, 2024
drupol
force-pushed
the
push-wnmlnxmlxxzn
branch
2 times, most recently
from
5926d12 to
8ad9b7a
Compare
|
@ofborg build python312Packages.captum |
|
1 similar comment
|
|
drupol
force-pushed
the
push-wnmlnxmlxxzn
branch
from
8ad9b7a to
fbadcd5
Compare
Comment on lines
80
to
100
| # Failing tests: AssertionError: 1.0 != 0.5 within 0.0001 delta (0.5 difference) | ||
| "test_TCAV_0_0" | ||
| "test_TCAV_0_1" | ||
| "test_TCAV_0_1_attr_to_inputs" | ||
| "test_TCAV_1_0_1" | ||
| "test_TCAV_1_0_b" | ||
| "test_TCAV_1_1_a" | ||
| "test_TCAV_1_1_a_wo_acc_metric" | ||
| "test_TCAV_1_1_b" | ||
| "test_TCAV_1_1_c" | ||
| "test_TCAV_1_1_d" | ||
| "test_TCAV_x_1_0_1" | ||
| "test_TCAV_x_1_0_1_attr_to_inputs" | ||
| "test_TCAV_x_1_0_1_w_flipped_class_id" | ||
| "test_TCAV_x_1_0_a" | ||
| "test_TCAV_x_1_0_b" | ||
| "test_TCAV_x_1_1_a" | ||
| "test_TCAV_x_1_1_b" | ||
| "test_TCAV_x_1_1_c" | ||
| "test_TCAV_x_1_1_c_concept_order_changed" | ||
| "test_TCAV_x_1_1_" |
There was a problem hiding this comment.
Maybe add tests/concept/test_tcav.py to disabledTestPaths instead.
Also, could you please report this upstream ?
drupol
force-pushed
the
push-wnmlnxmlxxzn
branch
from
fbadcd5 to
639d1c7
Compare
|
drupol
force-pushed
the
push-wnmlnxmlxxzn
branch
from
639d1c7 to
a2c826f
Compare
Comment on lines
+85
to
+86
| homepage = "https://github.com/pytorch/captum"; | ||
| license = lib.licenses.bsd3; |
There was a problem hiding this comment.
Suggested change
| homepage = "https://github.com/pytorch/captum"; | |
| license = lib.licenses.bsd3; | |
| homepage = "https://github.com/pytorch/captum"; | |
| changelog = "https://github.com/pytorch/captum/releases/tag/v${version}"; | |
| license = lib.licenses.bsd3; |
There was a problem hiding this comment.
Zut.... Je corrige ça asap.
facebook-github-bot
pushed a commit
to meta-pytorch/captum
that referenced
this pull request
Mar 25, 2025
Summary: While packaging this module for Nix (NixOS/nixpkgs#356087), I noticed during the tests that `flask` and `flask-compress` modules were missing from the `setup.py` file. Pull Request resolved: #1442 Reviewed By: cyrjano Differential Revision: D71814035 Pulled By: jjuncho fbshipit-source-id: 4e1cbc9e2e43dd88657063fade94405094bb4190
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.