Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/soteria: init module #355924

Merged
merged 2 commits into from
Nov 15, 2024
Merged

nixos/soteria: init module #355924

merged 2 commits into from
Nov 15, 2024

Conversation

JohnRTitor
Copy link
Contributor

@JohnRTitor JohnRTitor commented Nov 14, 2024 •
edited
Loading

This adds a security.soteria.enable option.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
  • Tested, as applicable:
    • Tested with my own configuration
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@JohnRTitor JohnRTitor requested a review from NotAShelf November 14, 2024 15:08
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Nov 14, 2024
@JohnRTitor JohnRTitor force-pushed the soteria branch 2 times, most recently from 533c04b to 76b5d0d Compare November 14, 2024 15:24
@JohnRTitor JohnRTitor requested a review from fufexan November 14, 2024 15:24
@github-actions github-actions bot added 8.has: documentation This PR adds or changes documentation 8.has: changelog labels Nov 14, 2024
fufexan
fufexan reviewed Nov 14, 2024
View reviewed changes
JohnRTitor
JohnRTitor commented Nov 14, 2024
View reviewed changes
Copy link
Contributor Author

@JohnRTitor JohnRTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ready now. I wonder if I should name it polkit-soteria, so that people can discover it easily.

@fufexan
Copy link
Contributor

fufexan commented Nov 14, 2024

You pushed but probably didn't commit before pushing. Changes are the same.

Should be ready now. I wonder if I should name it polkit-soteria, so that people can discover it easily.

Doesn't NixOS Search also search option descriptions?

@JohnRTitor
Copy link
Contributor Author

Doesn't NixOS Search also search option descriptions?

Yeah, I guess so.

@NotAShelf
Copy link
Member

Currently unable to test, but diff LGTM.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Nov 15, 2024
@JohnRTitor JohnRTitor merged commit b90d2b4 into NixOS:master Nov 15, 2024
47 checks passed
@JohnRTitor JohnRTitor deleted the soteria branch November 15, 2024 06:02
JohnRTitor added a commit to JohnRTitor/nix-conf that referenced this pull request Nov 15, 2024
@JohnRTitor
test security.soteria.enable from NixOS/nixpkgs#355924
11a9fed
@JohnRTitor JohnRTitor added the backport release-24.11 Backport PR automatically label Nov 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-24.11:

@github-actions github-actions bot mentioned this pull request Nov 15, 2024
Merged
1 task
@h7x4 h7x4 added the 8.has: module (new) This PR adds a module in `nixos/` label Nov 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

Git push to origin failed for release-24.11 with exitcode 1

@ambroisie ambroisie mentioned this pull request Dec 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fufexan fufexan fufexan approved these changes

@NotAShelf NotAShelf NotAShelf approved these changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (new) This PR adds a module in `nixos/` 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JohnRTitor @fufexan @NotAShelf @h7x4