Skip to content

python312Packages.unicorn: rename unicorn-emu input to unicorn#355779

Merged
pbsds merged 1 commit intoNixOS:masterfrom
pbsds:feat-unicorn-1731541243
Nov 23, 2024
Merged

python312Packages.unicorn: rename unicorn-emu input to unicorn#355779
pbsds merged 1 commit intoNixOS:masterfrom
pbsds:feat-unicorn-1731541243

Conversation

@pbsds
Copy link
Member

@pbsds pbsds commented Nov 13, 2024

unicorn-emu was meant to correspond to an alias which is now a throw

pointed out by #349431 (comment), it was not an issue due to the override

should be 0 rebuilds

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

unicorn-emu was meant to correspond to an alias which is now a throw
@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. labels Nov 13, 2024
@pbsds pbsds marked this pull request as ready for review November 13, 2024 23:45
@nix-owners nix-owners bot requested a review from natsukium November 13, 2024 23:46
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 14, 2024
@pbsds pbsds merged commit 362c5b1 into NixOS:master Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant