nixos-option: fix build against nix 2.24#355745
Merged
Mic92 merged 1 commit intoNixOS:masterfrom Nov 13, 2024
Merged
Conversation
13 tasks
fricklerhandwerk
approved these changes
Nov 13, 2024
Contributor
fricklerhandwerk
left a comment
There was a problem hiding this comment.
LGTM at a cursory glance
Ericson2314
reviewed
Nov 13, 2024
Ericson2314
reviewed
Nov 13, 2024
Ericson2314
approved these changes
Nov 13, 2024
Contributor
|
nix log /nix/store/0vj9pr9s98dkjv2imwdgp1vwfz5fnc8r-nixos-option.drv
warning: The interpretation of store paths arguments ending in `.drv` recently changed. If this command is now failing try again with '/nix/store/0vj9pr9s98dkjv2imwdgp1vwfz5fnc8r-nixos-option.drv^*'
Running phase: unpackPhase
@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking source archive /nix/store/gk2qs90xfhv0h19h8dca9hn9j3wkix6f-nixos-option
source root is nixos-option
Running phase: patchPhase
@nix { "action": "setPhase", "phase": "patchPhase" }
Running phase: updateAutotoolsGnuConfigScriptsPhase
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
Running phase: configurePhase
@nix { "action": "setPhase", "phase": "configurePhase" }
mesonConfigurePhase flags: --prefix=/nix/store/z3bnffna084is69k0qn2jhimjshav2gm-nixos-option --libdir=/nix/store/z3bnffna084is69k0qn2jh>
The Meson build system
Version: 1.6.0
Source dir: /build/nixos-option
Build dir: /build/nixos-option/build
Build type: native build
Project name: nixos-option
Project version: 0.1.6
C++ compiler for the host machine: g++ (gcc 13.3.0 "g++ (GCC) 13.3.0")
C++ linker for the host machine: g++ ld.bfd 2.43.1
Host machine cpu family: x86_64
Host machine cpu: x86_64
Found pkg-config: YES (/nix/store/f1gamyykr0f8n4afy910ass2jx2g9zkv-pkg-config-wrapper-0.29.2/bin/pkg-config) 0.29.2
Run-time dependency nix-main found: YES 2.18.9
Run-time dependency nix-store found: YES 2.18.9
Run-time dependency nix-expr found: YES 2.18.9
Run-time dependency nix-cmd found: YES 2.18.9
Did not find CMake 'cmake'
Found CMake: NO
Run-time dependency nix-flake found: NO (tried pkgconfig)
meson.build:10:16: ERROR: Dependency "nix-flake" not found, tried pkgconfig
A full log can be found at /build/nixos-option/build/meson-logs/meson-log.txtEDIT: nevermind, all good. I'd forgotten that i tested |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2024-11-13-nix-team-meeting-minutes-194/56211/1 |
Member
|
This effort would have been better spent on #313497 as nixos-option is a reimplementation of a bunch of the nix CLI front-end and is a giant pile of bad code. We should just get rid of it being a C++ API client and use the CLI and Nix expressions. Nevertheless, thanks for fixing the dependency in the default closure! |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
I noticed today we still have nix 2.18 in our default nixos closure. Bumping nixos-option fixes that. This pull request just does the minimum to get nixos-option build.
I have already follow up commits to improve things further: #355748
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.