deltachat-desktop: 1.46.8 -> 1.48.0#355575
Merged
dotlambda merged 2 commits intoNixOS:masterfrom Nov 18, 2024
Merged
Conversation
21 tasks
emilylange
reviewed
Nov 15, 2024
Member
emilylange
left a comment
There was a problem hiding this comment.
Hope this helps to get this going
fc7a8c9 to
b8a28d5
Compare
dotlambda
commented
Nov 16, 2024
Member
Author
There was a problem hiding this comment.
@Simon-Laux Does this look like the correct alternative to DELTA_CHAT_RPC_SERVER?
There was a problem hiding this comment.
yes. I first thought generating a @deltachat/stdio-rpc-server-<os>-<arch>/package.json might be necessary for detection, but looks like it already finds it just fine.
Member
Author
|
The Darwin build fails with Since I don't want to invest too much time into that I'll probably just mark it broken. |
b8a28d5 to
69c13d2
Compare
69c13d2 to
d783bfa
Compare
12 tasks
Contributor
|
Successfully created backport PR for |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Diff: deltachat/deltachat-desktop@v1.46.8...v1.48.0
Changelog: https://github.com/deltachat/deltachat-desktop/blob/v1.48.0/CHANGELOG.md
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.