Skip to content

haskellPackages: fixes for pkgsCross.aarch64-android-prebuilt#355543

Merged
maralorn merged 4 commits intoNixOS:haskell-updatesfrom
alexfmpe:ghc-9.10-android-prebuilt
Jun 4, 2025
Merged

haskellPackages: fixes for pkgsCross.aarch64-android-prebuilt#355543
maralorn merged 4 commits intoNixOS:haskell-updatesfrom
alexfmpe:ghc-9.10-android-prebuilt

Conversation

@alexfmpe
Copy link
Member

@alexfmpe alexfmpe commented Nov 12, 2024

Allows building a ton of non-TH libs under haskell.packages.910.

Libs needing TH fail with

<no location info>: error:
    Couldn't find a target code interpreter. Try with -fexternal-interpreter

The build of 9.8 fails due to some ghc bug somewhere when parsing the quadruple as if it was a triple. Still looking into it

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Nov 12, 2024
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise

$ nix-build -A pkgsCross.aarch64-android-prebuilt.haskell.packages.ghc910.primitive
...
aarch64-unknown-linux-android-ld: error: attempted static link of dynamic object /nix/store/dc4sk70a32x7qzvqr81rq9036cslrlw3-libiconv-aarch64-unknown-linux-android-1.17/lib/libiconv.so
<no location info>: error:
    `aarch64-unknown-linux-android-ld' failed in phase `Merge objects'. (Exit code: 1)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These errors have to be in the commit msg

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, I think

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise

$ nix-build -A pkgsCross.aarch64-android-prebuilt.haskell.packages.ghc910.attoparsec
...
RPATH of binary /nix/store/g6ncgk2b04mv722hh2jgfbixyawbwabv-attoparsec-aarch64-unknown-linux-android-0.14.4/lib/ghc-9.10.1/lib/aarch64-android-ghc-9.10.1-inplace/libHSattoparsec-0.14.4-GkMCGqk5eKArKmd1r9IB7-ghc9.10.1.so contains a forbidden reference to /build/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd actually note that this problem (/build leaking into rpaths` exists in a comment next to the default here. This is not really something we'd expect to be the case forever, a bug somewhere even.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fell through the cracks. Added a note as part of #414317

@nix-owners nix-owners bot requested a review from maralorn November 12, 2024 22:40
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 13, 2024
Copy link
Member

@maralorn maralorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot claim, that I really get what’s going on here, but this looks reasonable.
I don’t think this affects any hydra jobs, does it? If so this can go straight to master imo.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 13, 2024
@alexfmpe alexfmpe force-pushed the ghc-9.10-android-prebuilt branch from 2c16113 to e95a274 Compare November 15, 2024 21:29
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 15, 2024
@alexfmpe
Copy link
Member Author

alexfmpe commented Feb 9, 2025

After rebasing the builds now fail much earlier, I'll circle back to this in a few weeks

@alexfmpe
Copy link
Member Author

alexfmpe commented Mar 11, 2025

After rebasing the builds now fail much earlier, I'll circle back to this in a few weeks

#370180 #389028 gets this PR back into a working state

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 7, 2025
@alexfmpe alexfmpe force-pushed the ghc-9.10-android-prebuilt branch from e95a274 to 01a2489 Compare April 30, 2025 03:04
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 30, 2025
@nix-owners nix-owners bot requested a review from wolfgangwalther April 30, 2025 03:06
@alexfmpe alexfmpe force-pushed the ghc-9.10-android-prebuilt branch from 01a2489 to 4caa6c2 Compare April 30, 2025 04:22
@alexfmpe alexfmpe force-pushed the ghc-9.10-android-prebuilt branch from 4caa6c2 to 219685e Compare May 16, 2025 17:03
alexfmpe added 4 commits June 4, 2025 13:12
Fixes build of `pkgsCross.aarch64-android-prebuilt.haskell.packages.ghc910.primitive`:
```
aarch64-unknown-linux-android-ld: error: attempted static link of dynamic object /nix/store/dc4sk70a32x7qzvqr81rq9036cslrlw3-libiconv-aarch64-unknown-linux-android-1.17/lib/libiconv.so
<no location info>: error:
    `aarch64-unknown-linux-android-ld' failed in phase `Merge objects'. (Exit code: 1)
```
Fixes build of `pkgsCross.aarch64-android-prebuilt.haskell.packages.ghc910.attoparsec`:
```
RPATH of binary /nix/store/g6ncgk2b04mv722hh2jgfbixyawbwabv-attoparsec-aarch64-unknown-linux-android-0.14.4/lib/ghc-9.10.1/lib/aarch64-android-ghc-9.10.1-inplace/libHSattoparsec-0.14.4-GkMCGqk5eKArKmd1r9IB7-ghc9.10.1.so contains a forbidden reference to /build/
```
@alexfmpe alexfmpe force-pushed the ghc-9.10-android-prebuilt branch from 219685e to 2e79a5a Compare June 4, 2025 14:27
@maralorn maralorn merged commit a8e6185 into NixOS:haskell-updates Jun 4, 2025
15 of 18 checks passed
maralorn added a commit to reflex-frp/reflex-platform that referenced this pull request Jun 10, 2025
Causes infinite recursion

According to @alexfmpe unnecessary since: NixOS/nixpkgs#355543
maralorn added a commit to reflex-frp/reflex-platform that referenced this pull request Jun 11, 2025
Causes infinite recursion

According to @alexfmpe unnecessary since: NixOS/nixpkgs#355543
@alexfmpe alexfmpe deleted the ghc-9.10-android-prebuilt branch June 14, 2025 20:15
alexfmpe pushed a commit to alexfmpe/reflex-platform that referenced this pull request Oct 10, 2025
Causes infinite recursion

According to @alexfmpe unnecessary since: NixOS/nixpkgs#355543
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants