Skip to content

Comments

release.nix: add haskell.packages.ghc910.haskell-language-server #354537

Merged
maralorn merged 1 commit intoNixOS:masterfrom
jmatsushita:patch-1
Nov 13, 2024
Merged

release.nix: add haskell.packages.ghc910.haskell-language-server #354537
maralorn merged 1 commit intoNixOS:masterfrom
jmatsushita:patch-1

Conversation

@jmatsushita
Copy link
Contributor

As per #345947 ghc9101 is suppported by haskell-language-server so this should add it to hydra and the cache.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@jmatsushita
Copy link
Contributor Author

jmatsushita commented Nov 8, 2024

@maralorn if you have time to take a look that would be appreciated 🙏 I wasn't sure if this strictly needed to go to haskell-updates beforehand, but selfishly since I'd like hydra to build and cache aarch64-darwin I thought I'd submit against master.

@jmatsushita jmatsushita changed the title Add haskell.packages.ghc910.haskell-language-server haskell.packages.ghc910.haskell-language-server: add Nov 8, 2024
@jmatsushita
Copy link
Contributor Author

@ofborg eval

@jmatsushita jmatsushita changed the title haskell.packages.ghc910.haskell-language-server: add release.nix: add haskell.packages.ghc910.haskell-language-server Nov 8, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Nov 8, 2024
@maralorn
Copy link
Member

Oh, boy. We need some kind of checklist for this …

@maralorn maralorn merged commit 61f65fe into NixOS:master Nov 13, 2024
@maralorn
Copy link
Member

I guess we should add a loud comment into the release-haskell.nix file, that this place needs to be kept in sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants