release.nix: add haskell.packages.ghc910.haskell-language-server #354537
Merged
maralorn merged 1 commit intoNixOS:masterfrom Nov 13, 2024
Merged
release.nix: add haskell.packages.ghc910.haskell-language-server #354537maralorn merged 1 commit intoNixOS:masterfrom
maralorn merged 1 commit intoNixOS:masterfrom
Conversation
13 tasks
Contributor
Author
|
@maralorn if you have time to take a look that would be appreciated 🙏 I wasn't sure if this strictly needed to go to |
Contributor
Author
|
@ofborg eval |
Member
|
Oh, boy. We need some kind of checklist for this … |
Member
|
I guess we should add a loud comment into the release-haskell.nix file, that this place needs to be kept in sync. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #345947 ghc9101 is suppported by haskell-language-server so this should add it to hydra and the cache.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.