clash-rs: 0.7.0 -> 0.7.1

[ghost]

• https://github.com/Watfaq/clash-rs/releases/tag/v0.7.1

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[zi3m5f]

LGTM except:

Regarding the hash change for tuic-1.3.1, see Watfaq/clash-rs#635 (review)

A changing source hash without version update seems suspicious and we should always check why that happens.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 354419

---

x86_64-linux

✅ 1 package built:

• clash-rs

[zi3m5f]

As tuic simply didn't update the version in their Cargo.toml: LGTM 👍

Unrelated:
Can't we use Cargo.lock from upstream?

  lockFile = "${src}/Cargo.lock";

[zi3m5f]

Maybe I didn't spot it before but you committed as nanari instead of aucub?

And a nitpick: please don't rebase onto a newer master unless necessary. Luckily your changes are small, because reviewing your force-push with all the other changes is kinda hard ;)
Just git commit --amend or git rebase -i HEAD~1 will do.

[zi3m5f]

Unrelated: Can't we use Cargo.lock from upstream?
I don't know nix well and ofborg-eval went wrong. Can we really lockFile = "${src}/Cargo.lock";?

Sorry, was just wondering (and not thinking). That's "import from derivation" which isn't allowed in nixpkgs but works locally 🤷‍♂️

[Scrumplex]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 354419

---

x86_64-linux

✅ 1 package built:

• clash-rs

[github-actions]

Successfully created backport PR for release-24.11:

• [Backport release-24.11] clash-rs: 0.7.0 -> 0.7.1 #357672

[github-actions]

Git push to origin failed for release-24.11 with exitcode 1