Skip to content

libxmlxx3: 3.0.1 -> 3.2.5#354190

Merged
SuperSandro2000 merged 1 commit intoNixOS:stagingfrom
Kek5chen:libxmlxx-3.2.5
Aug 11, 2025
Merged

libxmlxx3: 3.0.1 -> 3.2.5#354190
SuperSandro2000 merged 1 commit intoNixOS:stagingfrom
Kek5chen:libxmlxx-3.2.5

Conversation

@Kek5chen
Copy link
Contributor

@Kek5chen Kek5chen commented Nov 7, 2024

Things done

bump version as stated in #350855

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from loskutov November 7, 2024 11:30
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Nov 7, 2024
@Kek5chen Kek5chen force-pushed the libxmlxx-3.2.5 branch 2 times, most recently from 055c93a to 52209c7 Compare November 8, 2024 16:34
@Kek5chen Kek5chen marked this pull request as ready for review November 8, 2024 16:35
@Kek5chen Kek5chen self-assigned this Nov 8, 2024
@ofborg ofborg bot added the 8.has: clean-up This PR removes packages or removes other cruft label Nov 8, 2024
@Kek5chen Kek5chen added 8.has: package (update) This PR updates a package to a newer version needs_reviewer labels Nov 10, 2024
Aleksanaa
Aleksanaa approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@Aleksanaa Aleksanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should target staging instead of master.

@Aleksanaa Aleksanaa added 12.approvals: 1 This PR was reviewed and approved by one person. and removed needs_reviewer labels Nov 11, 2024
@Kek5chen Kek5chen changed the base branch from master to staging November 11, 2024 17:15
@ofborg ofborg bot added 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. and removed 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Nov 12, 2024
SuperSandro2000
SuperSandro2000 reviewed Nov 20, 2024
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting should be done in an extra commit.

@Kek5chen Kek5chen force-pushed the libxmlxx-3.2.5 branch 2 times, most recently from a3c9108 to 78534f6 Compare November 21, 2024 21:39
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 22, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. and removed 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. labels Nov 22, 2024
toastal
toastal reviewed Apr 1, 2025
View reviewed changes
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 7, 2025
@Kek5chen Kek5chen force-pushed the libxmlxx-3.2.5 branch 2 times, most recently from af237f0 to 4a4631a Compare April 14, 2025 20:04
@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: vim Advanced text editor labels Apr 14, 2025
@github-actions github-actions bot added 6.topic: erlang General-purpose, concurrent, functional high-level programming language 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 6.topic: xfce The Xfce Desktop Environment 6.topic: stdenv Standard environment 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 6.topic: hardware Drivers, Firmware and Kernels 6.topic: nixos-container Imperative and declarative systemd-nspawn containers 6.topic: pantheon The Pantheon desktop environment 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: module system About "NixOS" module system internals 6.topic: docker tools Open-source software for deploying and running of containerized applications 6.topic: systemd Software suite that provides an array of system components for Linux operating systems. 6.topic: agda A dependently typed programming language / interactive theorem prover 6.topic: java Including JDK, tooling, other languages, other VMs 6.topic: R R is a programming language for statistical computing and data visualization. 6.topic: nim Nim programing language 6.topic: mate The MATE Desktop Environment labels Apr 21, 2025
@Kek5chen
Copy link
Contributor Author

Kek5chen commented Apr 21, 2025

holy S*** i am NEVER syncing branches using github again. How is it so bad.

@nix-owners
Copy link

nix-owners bot commented Apr 21, 2025

The PR's base branch is set to staging, but 43 commits from the master branch are included. Make sure you know the right base branch for your changes, then:

  • If the changes should go to the master branch, change the base branch to master
  • If the changes should go to the staging branch, rebase your PR onto the merge base with the staging branch: 
    # git rebase --onto $(git merge-base upstream/staging HEAD) $(git merge-base upstream/master HEAD)
git rebase --onto 78e2cd1a1590f8c70b329cbc7d13bb2ab5b5a16c b5918a6dac2a6ba6afc46dbabd4bb417f2776c89
git push --force-with-lease

@Kek5chen
Copy link
Contributor Author

Kek5chen commented Apr 21, 2025

also added myself to maintainers since i did majorly change the package.

Aleksanaa
Aleksanaa approved these changes Apr 21, 2025
View reviewed changes
Copy link
Member

@Aleksanaa Aleksanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to put it in after 25.05 branch off. Currently we should not allow mass rebuilds with update.

SuperSandro2000
SuperSandro2000 reviewed Apr 21, 2025
View reviewed changes
FliegendeWurst
FliegendeWurst reviewed Apr 21, 2025
View reviewed changes
@Kek5chen
Copy link
Contributor Author

Kek5chen commented Jul 8, 2025

can we continue? :)

@SuperSandroBot
Copy link

SuperSandroBot commented Jul 12, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 354190

Logs: https://github.com/SuperSandro2000/nixpkgs-review-gha/actions/runs/16230185564

x86_64-linux

✅ 2 packages built:
  • libxmlxx3
  • libxmlxx3.dev (libxmlxx3.dev.dev)

aarch64-linux

✅ 2 packages built:
  • libxmlxx3
  • libxmlxx3.dev (libxmlxx3.dev.dev)

x86_64-darwin (sandbox = true)

❌ 2 packages failed to build:
  • libxmlxx3
  • libxmlxx3.dev (libxmlxx3.dev.dev)

aarch64-darwin (sandbox = true)

❌ 2 packages failed to build:
  • libxmlxx3
  • libxmlxx3.dev (libxmlxx3.dev.dev)

@Kek5chen
Copy link
Contributor Author

Kek5chen commented Aug 11, 2025

@SuperSandro2000 so, can we continue..?

@LunNova LunNova mentioned this pull request Aug 12, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FliegendeWurst FliegendeWurst FliegendeWurst left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@Aleksanaa Aleksanaa Aleksanaa approved these changes

@loskutov loskutov Awaiting requested review from loskutov

@emilazy emilazy Awaiting requested review from emilazy

@toastal toastal Awaiting requested review from toastal

Assignees

@Kek5chen Kek5chen

Labels

6.topic: policy discussion Discuss policies to work in and around Nixpkgs 8.has: clean-up This PR removes packages or removes other cruft 8.has: documentation This PR adds or changes documentation 8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

Stdenv
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@Kek5chen @SuperSandroBot @toastal @SuperSandro2000 @FliegendeWurst @emilazy @Aleksanaa @mdaniels5757 @wegank