Skip to content

nixVersions.nix_2_19: drop#354148

Merged
Mic92 merged 3 commits intoNixOS:masterfrom
Mic92:drop-nix-2.19
Nov 27, 2024
Merged

nixVersions.nix_2_19: drop#354148
Mic92 merged 3 commits intoNixOS:masterfrom
Mic92:drop-nix-2.19

Conversation

@Mic92
Copy link
Member

@Mic92 Mic92 commented Nov 7, 2024

We are no longer actively fixing bugs in nix 2.19. Other nix versions will follow in a bit.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@tomodachi94 tomodachi94 added the 6.topic: old-versions Tickets pertaining to ongoing support of outdated versions of packages label Nov 7, 2024
@Mic92 Mic92 marked this pull request as draft November 7, 2024 06:34
@Mic92
Copy link
Member Author

Mic92 commented Nov 7, 2024

@roberth I am trying to drop this but your hercules-ci-cnix-store depends on it.

Also nixd, cc @inclyc

@Mic92
Copy link
Member Author

Mic92 commented Nov 7, 2024

If you want to take maintenance over for these nix versions, let me know, but the nix team cannot support so many different nix versions.

@Mic92
Copy link
Member Author

Mic92 commented Nov 7, 2024

I started updating nixd for nix 2.24 here: nix-community/nixd#613

@roberth
Copy link
Member

roberth commented Nov 7, 2024

I'll update the hercules-ci-cnix-* bindings.

@roberth
Copy link
Member

roberth commented Nov 15, 2024

Mini update update: I've released the updated packages to hackage. Next I'll make a backportable update by cherry-picking 3ff89d8, either during the weekend or on Monday.

@Mic92
Copy link
Member Author

Mic92 commented Nov 25, 2024

Last offender: bluskript/nix-inspect#18

@Mic92 Mic92 force-pushed the drop-nix-2.19 branch 2 times, most recently from 6b62968 to 7e035e1 Compare November 25, 2024 15:07
@ofborg ofborg bot added the ofborg-internal-error Ofborg encountered an error label Nov 26, 2024
@Mic92 Mic92 marked this pull request as ready for review November 26, 2024 08:06
@Mic92 Mic92 mentioned this pull request Nov 26, 2024
13 tasks
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 26, 2024
@ofborg ofborg bot added the 8.has: clean-up This PR removes packages or removes other cruft label Nov 27, 2024
@ofborg ofborg bot requested a review from bluskript November 27, 2024 01:25
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Nov 27, 2024
@Mic92 Mic92 merged commit 8b173e8 into NixOS:master Nov 27, 2024
@Mic92 Mic92 deleted the drop-nix-2.19 branch November 27, 2024 21:03
@cole-h cole-h removed the ofborg-internal-error Ofborg encountered an error label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: old-versions Tickets pertaining to ongoing support of outdated versions of packages 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants