lix: disable tests on x86_64-darwin#353485
Closed
eilvelia wants to merge 1 commit intoNixOS:masterfrom
Closed
Conversation
Member
|
We should not be disabling failing tests, that doesn't fix the problem it just ignores it. |
Member
Author
|
I'm not sure what the usual practices in nixpkgs are, but my thinking was: (a) the failing tests look to be related to the test suite itself and not to the actual differences in behavior; (b) fixing that may take a long time, while it is beneficial to get the binaries into the nix cache; (c) it is kinda sad to disable LTO which appears to actually work fine. I guess disabling LTO is a safer option. I wanted to change this PR to disable LTO instead, but I see that you already opened #353576, thanks, and so I'm closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
Fixes #337036
lix build has been broken on x86_64-darwin since the update to lix 2.91: https://hydra.nixos.org/job/nixpkgs/trunk/lixVersions.latest.x86_64-darwin/all (this is apparently caused by enabled LTO).
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.