Skip to content

lix: disable tests on x86_64-darwin#353485

Closed
eilvelia wants to merge 1 commit intoNixOS:masterfrom
eilvelia:lix-darwin
Closed

lix: disable tests on x86_64-darwin#353485
eilvelia wants to merge 1 commit intoNixOS:masterfrom
eilvelia:lix-darwin

Conversation

@eilvelia
Copy link
Member

@eilvelia eilvelia commented Nov 3, 2024

Things done

Fixes #337036

lix build has been broken on x86_64-darwin since the update to lix 2.91: https://hydra.nixos.org/job/nixpkgs/trunk/lixVersions.latest.x86_64-darwin/all (this is apparently caused by enabled LTO).

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@lilyball
Copy link
Member

lilyball commented Nov 4, 2024

We should not be disabling failing tests, that doesn't fix the problem it just ignores it.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Nov 4, 2024
@ofborg ofborg bot requested review from Qyriad and RaitoBezarius November 4, 2024 10:14
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 4, 2024
@eilvelia
Copy link
Member Author

eilvelia commented Nov 4, 2024

I'm not sure what the usual practices in nixpkgs are, but my thinking was: (a) the failing tests look to be related to the test suite itself and not to the actual differences in behavior; (b) fixing that may take a long time, while it is beneficial to get the binaries into the nix cache; (c) it is kinda sad to disable LTO which appears to actually work fine. I guess disabling LTO is a safer option. I wanted to change this PR to disable LTO instead, but I see that you already opened #353576, thanks, and so I'm closing this.

@eilvelia eilvelia closed this Nov 4, 2024
@eilvelia eilvelia deleted the lix-darwin branch November 4, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failure: lix on x86_64-darwin

2 participants