Skip to content

rhino: 1.7R2 -> 1.7.15, various improvements#353254

Closed
tomodachi94 wants to merge 5 commits intoNixOS:masterfrom
tomodachi94:update/rhino/1.7.15
Closed

rhino: 1.7R2 -> 1.7.15, various improvements#353254
tomodachi94 wants to merge 5 commits intoNixOS:masterfrom
tomodachi94:update/rhino/1.7.15

Conversation

@tomodachi94
Copy link
Member

@tomodachi94 tomodachi94 commented Nov 3, 2024

Remaining todos:

  • Add update script
  • Format with nixfmt-rfc-style
  • Move it to by-name
  • Add self to maintainers
  • Migrate to finalAttrs
  • Use stdenvNoCC
  • Determine why hardeningDisable is set how it is
  • Figure out how to build rhino-all.jar
  • Test that this doesn't break LibreOffice Fresh

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@tomodachi94 tomodachi94 force-pushed the update/rhino/1.7.15 branch 2 times, most recently from 843c3c2 to de426e3 Compare November 3, 2024 02:15
@tomodachi94 tomodachi94 changed the title rhino: 1.7R2 -> 1.7.15 rhino: 1.7R2 -> 1.7.15, various improvements Nov 3, 2024
@ofborg ofborg bot added the 8.has: clean-up This PR removes packages or removes other cruft label Nov 3, 2024
@ofborg ofborg bot requested a review from 7c6f434c November 3, 2024 15:07
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Nov 3, 2024
@tomodachi94 tomodachi94 added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 9, 2024
@tomodachi94 tomodachi94 removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 9, 2024
@tomodachi94 tomodachi94 added the 9.needs: upstream fix This PR needs upstream to change something label Nov 30, 2024
@tomodachi94
Copy link
Member Author

tomodachi94 commented Nov 30, 2024

Currently blocked. We need rhino-all for LibreOffice, but that hasn't been released yet. I've asked nicely for upstream to release a new version.

The patch that introduces rhino-all is part of a monolithic patch that conflicts with the current release, making it difficult to simply include it in patches.

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 10, 2024
@nixpkgs-ci nixpkgs-ci bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 25, 2025
@tomodachi94
Copy link
Member Author

Superseded by #424548

@github-project-automation github-project-automation bot moved this from In progress to Done in Java Sep 29, 2025
@tomodachi94 tomodachi94 deleted the update/rhino/1.7.15 branch September 29, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: clean-up This PR removes packages or removes other cruft 9.needs: upstream fix This PR needs upstream to change something 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants