postgresql: use team

[Ma27]

Main motivation for this is that I'd like to get a feature-freeze ping: we have old stuff to remove and quite a bit of things ongoing here, so explicitly being part of the check-up process seems like a good thing.

Also added myself and wolfgangwalther to it.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[wolfgangwalther]

Ah, thanks for taking that up. I wanted to add to the new OWNERS file anyway, but didn't get around to that, yet. Didn't know there was a postgres team already, cool!

Happy to be in it, ofc.

[wolfgangwalther]

Let's also take the chance to discuss / ask about the other maintainers listed here. My experience over this year was, that nobody else except @Ma27 ever commented on any of the related Pull Requests I made - which is absolutely fine. In the beginning it was just confusing to me, because the package looked well maintained from looking at the list of maintainers - but it turned out not to be true.

Looking at activity in nixpkgs in general and at postgresql specifically, I think we should:

• Remove @danbst from the list of maintainers, last active in nixpkgs in ~2020 (pull requests, commits).
• Check-in with @globin, who committed to nixpkgs as of July this year, but apparently never had any PRs related to PostgreSQL. @globin do you still want to be a maintainer for PostgreSQL? Seems like this could be a case of "I'd like to be notified about changes", in which case I'd suggest we add a comment accordingly, so that people looking at the list can tell they wouldn't need to expect an answer / review here?
• Check-in with @ivan who recently removed himself from postgresqlPackages.pg_embedding in prisma-engines, postgresqlPackages.pg_embedding: remove myself from maintainers #324978. @ivan did you just forget to remove yourself here or would you like to remain maintainer for postgresql?
• Check-in with @thoughtpolice - you still seem to be very active on nixpkgs, but haven't heard anything from you in the context of postgresql. Would you (still) like to be part of the postgresql team?

[thoughtpolice]

I still do use postgres-with-nix behind the scenes and even did some commercial work on it last year, but mostly it's just because I'm spread very thin and don't have time to give it singular focus and many of the PRs require much more attention than I have available.

I'm happy to remain on the maintainers list as a point-of-contact for questions though.

[Ma27]

@wolfgangwalther just created a team for postgres with all members in this branch.

What do we do with the other maintainers? It's not super-urgent to merge it now, but I'd like to not stall this because we're awaiting feedback.

[Ma27]

Perhaps we want to move all postgresql-related tests into nixos/tests/postgresql? That way, we could also add the subtree here.

[wolfgangwalther]

Agreed!

[wolfgangwalther]

Even with #352966 open, I think it should be fine to move those files here. A rebase should be simple, because git should detect the renames.

[wolfgangwalther]

What do we do with the other maintainers? It's not super-urgent to merge it now, but I'd like to not stall this because we're awaiting feedback.

Let's remove danbst as suggestd above in this PR, then merge. We'll still wait for feedback here and if we don't get any we will remove the others later?

[Ma27]

Done.
Let's perform the restructuring of the tests in #352966 if that's OK for you.

[wolfgangwalther]

Let's perform the restructuring of the tests in #352966 if that's OK for you.

👍

[Ma27]

So, the team exists, I now need somebody to add nixpkgs in read-only mode to be added to the team:

You do not have sufficient permissions to add the nixpkgs repository to this team

cc @Lassulus @zimbatm can one of you add nixpkgs (role: readonly) to https://github.com/orgs/NixOS/teams/postgres ?

[wolfgangwalther]

While you're on this, could you remove me from postgis and pg_safeupdate as maintainer together with the addition of the team? We only added myself, so that I would be notified about potential breaking changes there, but with the postgres team in ci/OWNERS, I will be notified anyway.

[wolfgangwalther]

@Ma27 I see a 👍 by lassulus on:

can one of you add nixpkgs (role: readonly) to https://github.com/orgs/NixOS/teams/postgres

Can you trigger CI again?