Closed
Conversation
added 4 commits
February 15, 2018 21:42
This change enables us to call toPythonModules in package definitions. Cfr following commit: 'jupyter: init standalone package'
This is a meta package for creating a jupyter notebook kernel definition folder. It must be used in conjunction with jupyter or jupyterhub to make different environements availables.
Member
|
The diff is fine, there is no sane way to handle the complexity of npm modules. |
Contributor
|
I'm glad to see it works with another language. |
3be5555 to
c845453
Compare
Contributor
Author
|
I upgraded it to a Node 8 package because a user probably wants the latest feature in the REPL.
Agreed, but I lack the Nix knowledge to know how. |
41ba684 to
343b597
Compare
Member
|
This needs to be rebased. If you still want to get this in, please open a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Added the IJavascript Jupyter Notebook kernel to the (so far unmerged) pull request #33673 by @aborsu
I added a
javascriptkernel topkgs/development/misc/jupyterKernels/default.nixwhich requires the packagenodePackages.ijavascript.Following the steps of the npm packaging documentation, I added the
ijavascriptpackage topkgs/development/node-packages/node-packages-v6.jsonand added build input overrides inpkgs/development/node-packages/default-v6.nixbecause the package depends on node-gyp and zeromq.Then I ran the
generate.shscript. Unfortunately it generated a huge diff of thenode-packages-v?.nixfiles.I tested the updated module with this configuration:
Both python3 and javascript notebooks run fine.
Note that
proxyWebsockets = trueis required else the browser will fail to connect to the notebook. I discovered it by enabling debug logging in the nixos jupyter service.NPM dependencies for the notebook need to be installed into the
notebookDir.Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)