tesseract: ensure fixupPhase is run, e.g. ensuring library codesigning on darwin#352788
Merged
vcunat merged 1 commit intoNixOS:masterfrom Dec 23, 2024
Merged
tesseract: ensure fixupPhase is run, e.g. ensuring library codesigning on darwin#352788vcunat merged 1 commit intoNixOS:masterfrom
vcunat merged 1 commit intoNixOS:masterfrom
Conversation
ofborg
bot
added
6.topic: darwin
13 tasks
sarahec
added
the
0.kind: ZHF Fixes
Contributor
|
Result of 49 packages marked as broken and skipped:
2 packages failed to build:
51 packages built:
|
Contributor
|
Hi, thanks for fixing this. Any idea when it can be merged 🙏? |
Contributor
|
Successfully created backport PR for |
1 task
SuperSandro2000
requested changes
Dec 25, 2024
| nativeBuildInputs = [ makeWrapper ]; | ||
|
|
||
| buildCommand = '' | ||
| phases = [ "buildPhase" "fixupPhase" ]; |
Member
There was a problem hiding this comment.
phases should not be set in packages
Member
There was a problem hiding this comment.
This PR still definitely seemed like an improvement, though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the tesseract wrapper replaces the phases in tesseractBase with it's buildCommand, this prevents running e.g. the fixupPhase which would codesign the modified library for darwin.
This change ensures the fixupPhase is executed, ensuring a valid code signature for
libtesseract.5.dylib.Before the change:
After the change:
Fixes #350072.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.