Skip to content

sketchybar: use the new apple-sdk#352647

Closed
azuwis wants to merge 1 commit intoNixOS:masterfrom
azuwis:push-ruvqxrkkzylv
Closed

sketchybar: use the new apple-sdk#352647
azuwis wants to merge 1 commit intoNixOS:masterfrom
azuwis:push-ruvqxrkkzylv

Conversation

@azuwis
Copy link
Contributor

@azuwis azuwis commented Oct 31, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@azuwis azuwis force-pushed the push-ruvqxrkkzylv branch from bfe7a63 to cd3a083 Compare October 31, 2024 16:19
@azuwis
Copy link
Contributor Author

azuwis commented Oct 31, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 352647


aarch64-darwin

✅ 1 package built:
  • sketchybar

x86_64-darwin

✅ 1 package built:
  • sketchybar

@azuwis azuwis marked this pull request as ready for review October 31, 2024 16:51
@ofborg ofborg bot requested a review from khaneliman October 31, 2024 22:39
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Oct 31, 2024
@khaneliman
Copy link
Contributor

duplicate of #352620

@FliegendeWurst FliegendeWurst added the 6.topic: darwin Running or building packages on Darwin label Oct 31, 2024
@azuwis
Copy link
Contributor Author

azuwis commented Oct 31, 2024

@khaneliman I think we should add (darwinMinVersionHook "10.13"), as upstream set x86_64-apple-macos10.13 here https://github.com/FelixKratz/SketchyBar/blob/ed1684d348fc4d4319c7f9835141524c524bacb3/makefile#L36

@khaneliman
Copy link
Contributor

@khaneliman I think we should add (darwinMinVersionHook "10.13"), as upstream set x86_64-apple-macos10.13 here https://github.com/FelixKratz/SketchyBar/blob/ed1684d348fc4d4319c7f9835141524c524bacb3/makefile#L36

I updated it, I also bumped the SDK version because they have availability checks throughout the codebase for different symbols.

@azuwis
Copy link
Contributor Author

azuwis commented Nov 1, 2024

Close this one.

I wonder why ofborg did not add me as reviewer in #352620 after eval.

@azuwis azuwis closed this Nov 1, 2024
@azuwis azuwis deleted the push-ruvqxrkkzylv branch November 1, 2024 00:45
@khaneliman
Copy link
Contributor

khaneliman commented Nov 1, 2024

for some reason i can't select you as a reviewer either
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants