[staging-next] tree-wide: switch initrd generators back to gnu cpio #352498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yu-re-ka
changed the title
github-actions
bot
added
6.topic: nixos
yu-re-ka
force-pushed
the
fix-initrd-secrets
branch
from
159ff33 to
34a4032
Compare
Contributor
Author
|
Weird amd-ucode is failing
|
Originally, we switched to bsdtar from libarchive to solve a reproducibility issue related to hardlinks As of gnu cpio 2.14 the --ignore-dirnlink option is introduced and now included in --reproducible, which solves this issue By switching back, we are in turn solving an issue in libarchive >=3.7.5 erroring out with "Error reading archive -: (null)" Change-Id: Ib6140d599b6547d8e941b0251ce996e303c41fa6
yu-re-ka
force-pushed
the
fix-initrd-secrets
branch
from
34a4032 to
0f216e2
Compare
emilazy
approved these changes
Oct 31, 2024
Member
emilazy
left a comment
emilazy
left a comment
There was a problem hiding this comment.
Installer test passes and initrd secrets have been manually tested.
Member
|
Uh. So do we also do this for |
Member
|
If we’re bumping |
Contributor
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, we switched to bsdtar from libarchive to solve a reproducibility issue related to hardlinks
As of gnu cpio 2.14 the --ignore-dirnlink option is introduced and now included in --reproducible, which solves this issue
By switching back, we are in turn solving an issue in libarchive >=3.7.5 erroring out with "Error reading archive -: (null)"
Change-Id: I9eb6fc3e96e4f2676aedb147127d05b08e10fa92
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.