Skip to content

wealthfolio: init at 1.0.18#351459

Merged
Aleksanaa merged 1 commit intoNixOS:masterfrom
kilianar:wealthfolio-init
Oct 28, 2024
Merged

wealthfolio: init at 1.0.18#351459
Aleksanaa merged 1 commit intoNixOS:masterfrom
kilianar:wealthfolio-init

Conversation

@kilianar
Copy link
Contributor

This pull request adds wealthfolio, a tool for tracking investments with local data storage, at version 1.0.18.

Note: Version 1.0.19 is also available but requires tauri2 support. This support will be introduced in nixpkgs once pull request #346277 has been merged.

Resolves #341027.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@alexandru0-dev
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 351459


x86_64-linux

❌ 1 package failed to build:
  • wealthfolio

Build phase with the following error:

   > ERROR: The Cargo.lock file doesn't exist
   >
   > Cargo.lock is needed to make sure that cargoHash/cargoSha256 doesn't change
   > when the registry is updated.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 26, 2024
@kilianar
Copy link
Contributor Author

It’s surprising to see an issue with a missing Cargo.lock file, as there is one located in src-tauri/. Additionally, I ran nixpkgs-review on this pull request, and it completed successfully without any errors.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 351459


x86_64-linux

✅ 1 package built:
  • wealthfolio

@alexandru0-dev
Copy link
Contributor

@kilianar i've checked with another machine and also ofborg has the same issue
https://logs.ofborg.org/?key=nixos/nixpkgs.351459&attempt_id=4e1963ac-f489-4a41-850a-dee4add8ad49

@kilianar
Copy link
Contributor Author

@alexandru0-dev Thanks for checking again! I was finally able to reproduce the issue. I believe I couldn't replicate it initially because the necessary Cargo dependencies were already present in my Nix store from previous packaging attempts. As a result, Nix bypassed reading Cargo.lock and used the cached dependencies instead. Once I deleted the relevant files from my Nix store, the error appeared as expected.

@alexandru0-dev
Copy link
Contributor

@kilianar you're welcome :)
btw here is the nixpkgs-review ouput

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 351459


x86_64-linux

✅ 1 package built:
  • wealthfolio

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 28, 2024
@Aleksanaa Aleksanaa merged commit 304d6bf into NixOS:master Oct 28, 2024
@kilianar kilianar deleted the wealthfolio-init branch October 28, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Package request: wealthfolio

4 participants