Restore linuxManualConfig as linux/kernel/manual-config.nix#35094
Merged
cstrahan merged 1 commit intoNixOS:masterfrom Feb 20, 2018
thefloweringash:restore-linux-manual-config
Merged
Restore linuxManualConfig as linux/kernel/manual-config.nix#35094cstrahan merged 1 commit intoNixOS:masterfrom thefloweringash:restore-linux-manual-config
cstrahan merged 1 commit intoNixOS:masterfrom
thefloweringash:restore-linux-manual-config
Conversation
Contributor
|
Indeed - otherwise the existing nixpkgs/pkgs/top-level/all-packages.nix Lines 13292 to 13296 in bd7d5b3 Note that it expects to be able to pass I'll merge this, as it does appear to be a minor oversight. |
Member
|
sorry for the inconvenience. I plan to write some doc once #34672 gets merged. I will mention |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
In a recent pull request (#34351) the definition of
buildLinuxchanged fromlinux/kernel/manual-config.nixtolinux/kernel/generic.nix. SincelinuxManualConfigis an alias ofbuildLinux, this means thatlinuxManualConfignow points tolinux/kernel/generic.nix.I haven't examined the details of the work in this area, but it reads like a simple oversight. The documentation also doesn't seem to have a section on how to build a manually configured kernel. Is
linuxManualConfigthe intended way?Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)