libpsl: enable Windows builds#350819
Merged
Aleksanaa merged 1 commit intoNixOS:masterfrom Oct 27, 2024
Merged
Conversation
Bringing python3 into the mix breaks Windows builds, which in turn prevents curl from building on Windows in the default configuration for nixpkgs. Excluding python3 from the buildInputs on Windows prevents that problem The rest of the changes are nixfmt changes
ofborg
bot
added
10.rebuild-darwin: 0
Contributor
Author
|
Related to #351010 but that fix still doesn't enable the default pyhthon 3.12 package to build, so this package would need to pull python311 specifically for Windows targets. |
Aleksanaa
approved these changes
Oct 27, 2024
Member
Aleksanaa
left a comment
Aleksanaa
left a comment
There was a problem hiding this comment.
Since it's still an exotic platform, I'd assume it works, lgtm as long as it doesn't break others
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bringing python3 into the mix breaks Windows builds, which in turn
prevents curl from building on Windows in the default configuration for
nixpkgs. Excluding python3 from the buildInputs on Windows prevents that
problem
The rest of the changes are nixfmt changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.