Skip to content

Comments

teams-for-linux: 1.11.0 -> 1.11.2#350497

Merged
drupol merged 3 commits intoNixOS:masterfrom
khaneliman:teams
Oct 23, 2024
Merged

teams-for-linux: 1.11.0 -> 1.11.2#350497
drupol merged 3 commits intoNixOS:masterfrom
khaneliman:teams

Conversation

@khaneliman
Copy link
Contributor

@khaneliman khaneliman commented Oct 22, 2024

Changelog: https://github.com/IsmaelMartinez/teams-for-linux/releases/tag/v1.11.2
Handle electron deprecation: #350549

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@khaneliman
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 350497


x86_64-linux

✅ 1 package built:
  • teams-for-linux

aarch64-linux

❌ 1 package failed to build:
  • teams-for-linux

x86_64-darwin

✅ 1 package built:
  • teams-for-linux

aarch64-darwin

✅ 1 package built:
  • teams-for-linux

@khaneliman
Copy link
Contributor Author

khaneliman commented Oct 22, 2024

Looks like aarch64 qemu failure on version check since I don't have native aarch64 and setuid configured right. Should be safe to ignore.

> Did not find version 1.11.2 in the output of the command /nix/store/1qn54srybqaqkany4w38s4r304r4z05g-teams-for-linux-1.11.2/bin/teams-for-linux --version
┃        > [1604:1022/154336.670370:FATAL:setuid_sandbox_host.cc(158)] The SUID sandbox helper binary was found, but is not configured correctly. Rather than run without sandboxing I'm aborting now. You need to make sure that {…
┃        > qemu: uncaught target signal 5 (Trace/breakpoint trap) - core dumped

Don't waste time calling --help
@ofborg ofborg bot requested review from chvp, muscaln and qjoly October 22, 2024 18:06
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 22, 2024
Looks like upstream bumped electron version, already.
@khaneliman
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 350497


x86_64-linux

✅ 1 package built:
  • teams-for-linux

aarch64-linux

❌ 1 package failed to build:
  • teams-for-linux

x86_64-darwin

✅ 1 package built:
  • teams-for-linux

aarch64-darwin

✅ 1 package built:
  • teams-for-linux

@khaneliman khaneliman requested a review from drupol October 23, 2024 16:18
@drupol drupol merged commit 2e81cfb into NixOS:master Oct 23, 2024
@khaneliman khaneliman deleted the teams branch October 23, 2024 16:34
@github-actions
Copy link
Contributor

Backport failed for release-24.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.05
git worktree add -d .worktree/backport-350497-to-release-24.05 origin/release-24.05
cd .worktree/backport-350497-to-release-24.05
git switch --create backport-350497-to-release-24.05
git cherry-pick -x bce77b92c607c68fda5606294317c3625671897e edbaf29b2ae0e34bdc92df725454975c00358094 0cf4af90813d31923d775d5f319c6f24cf8afc1b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants