teams-for-linux: 1.11.0 -> 1.11.2#350497
Merged
drupol merged 3 commits intoNixOS:masterfrom Oct 23, 2024
Merged
Conversation
Contributor
Author
|
Contributor
Author
|
Looks like aarch64 qemu failure on version check since I don't have native aarch64 and setuid configured right. Should be safe to ignore. > Did not find version 1.11.2 in the output of the command /nix/store/1qn54srybqaqkany4w38s4r304r4z05g-teams-for-linux-1.11.2/bin/teams-for-linux --version
┃ > [1604:1022/154336.670370:FATAL:setuid_sandbox_host.cc(158)] The SUID sandbox helper binary was found, but is not configured correctly. Rather than run without sandboxing I'm aborting now. You need to make sure that {…
┃ > qemu: uncaught target signal 5 (Trace/breakpoint trap) - core dumped |
Don't waste time calling --help
Looks like upstream bumped electron version, already.
21 tasks
Contributor
Author
|
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.05
git worktree add -d .worktree/backport-350497-to-release-24.05 origin/release-24.05
cd .worktree/backport-350497-to-release-24.05
git switch --create backport-350497-to-release-24.05
git cherry-pick -x bce77b92c607c68fda5606294317c3625671897e edbaf29b2ae0e34bdc92df725454975c00358094 0cf4af90813d31923d775d5f319c6f24cf8afc1b |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: https://github.com/IsmaelMartinez/teams-for-linux/releases/tag/v1.11.2
Handle electron deprecation: #350549
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.