Skip to content

cargo-tauri.hook: use finalPackage as cargo-tauri#350002

Closed
TomaSajt wants to merge 3 commits intoNixOS:masterfrom
TomaSajt:cargo-tauri
Closed

cargo-tauri.hook: use finalPackage as cargo-tauri#350002
TomaSajt wants to merge 3 commits intoNixOS:masterfrom
TomaSajt:cargo-tauri

Conversation

@TomaSajt
Copy link
Contributor

@TomaSajt TomaSajt commented Oct 20, 2024

This PR simplifies usage of cargo-tauri.hook when cargo-tauri is overridden

This PR should not cause any rebuilds.


The related question that still remains is how to package cargo_tauri_2 and how a cargo-tauri_2 vs cargo-tauri_1 split will work inside pkgs/by-name

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Oct 20, 2024
@TomaSajt TomaSajt requested a review from getchoo October 23, 2024 10:15
Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I hadn't thought of something like this before

The related question that still remains is how to package cargo_tauri_2 and how a cargo-tauri_2 vs cargo-tauri_1 split will work inside pkgs/by-name

That's being done in #346277, which this will be a major help in (and should now be merged after this)

@TomaSajt
Copy link
Contributor Author

Okay, I just put meta into the overrideAttrs, hopefully that's OK.

Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the wait. Moving meta and passthru to the overrideAttrs arguments is fine with me. Thanks!

@getchoo getchoo added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 29, 2024
@ofborg ofborg bot added the 8.has: clean-up This PR removes packages or removes other cruft label Oct 29, 2024
@wegank wegank removed the 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. label Oct 31, 2024
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 31, 2024
@getchoo getchoo added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Nov 1, 2024
@wegank wegank removed the 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. label Nov 1, 2024
@TomaSajt
Copy link
Contributor Author

Closing in favor of #354999

@TomaSajt TomaSajt closed this Nov 16, 2024
@TomaSajt TomaSajt deleted the cargo-tauri branch January 20, 2026 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants