cargo-tauri.hook: use finalPackage as cargo-tauri#350002
Closed
TomaSajt wants to merge 3 commits intoNixOS:masterfrom
Closed
cargo-tauri.hook: use finalPackage as cargo-tauri#350002TomaSajt wants to merge 3 commits intoNixOS:masterfrom
TomaSajt wants to merge 3 commits intoNixOS:masterfrom
Conversation
getchoo
requested changes
Oct 23, 2024
Member
getchoo
left a comment
There was a problem hiding this comment.
Thanks! I hadn't thought of something like this before
The related question that still remains is how to package cargo_tauri_2 and how a cargo-tauri_2 vs cargo-tauri_1 split will work inside pkgs/by-name
That's being done in #346277, which this will be a major help in (and should now be merged after this)
Contributor
Author
|
Okay, I just put |
getchoo
approved these changes
Oct 29, 2024
Member
getchoo
left a comment
There was a problem hiding this comment.
Sorry for the wait. Moving meta and passthru to the overrideAttrs arguments is fine with me. Thanks!
getchoo
approved these changes
Nov 1, 2024
Contributor
Author
|
Closing in favor of #354999 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simplifies usage of cargo-tauri.hook when cargo-tauri is overridden
This PR should not cause any rebuilds.
The related question that still remains is how to package
cargo_tauri_2and how acargo-tauri_2vscargo-tauri_1split will work insidepkgs/by-nameThings done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.