Skip to content

Adding @0x4A6F to maintainers.nix#34984

Merged
Mic92 merged 3 commits intoNixOS:masterfrom
0x4A6F:0x4A6F
Feb 15, 2018
Merged

Adding @0x4A6F to maintainers.nix#34984
Mic92 merged 3 commits intoNixOS:masterfrom
0x4A6F:0x4A6F

Conversation

@0x4A6F
Copy link
Member

@0x4A6F 0x4A6F commented Feb 14, 2018

Motivation for this change

Trying to add my handle @0x4A6F to maintainers, to contribute to nixpkgs.

Looking forward for inclusion of #34842.

Things done

Adding github handle starting with decimal to maintainers.nix, but this will break nix expression.
nix-repl lib/maintainers.nix

Welcome to Nix version 1.11.16. Type :? for help.

Loading ‘lib/maintainers.nix’...
error: syntax error, unexpected INT, at /home/user/repositories/github.com/0x4A6F/nixpkgs-origin/lib/maintainers.nix:10:3
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 14, 2018
@Mic92 Mic92 merged commit 4ef3b1b into NixOS:master Feb 15, 2018
@vcunat
Copy link
Member

vcunat commented Feb 15, 2018

@vcunat
Copy link
Member

vcunat commented Feb 15, 2018

Though this case... "0x4A6F" = "...." could be used and then lib.maintainers."0x4A6F", but it wouldn't be very nice either.

@0x4A6F 0x4A6F mentioned this pull request Mar 7, 2019
10 tasks
@0x4A6F 0x4A6F deleted the 0x4A6F branch November 24, 2019 09:52
@Janik-Haag Janik-Haag added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants