aliases: keep the utillinux alias until node2nix is phased out#349783
aliases: keep the utillinux alias until node2nix is phased out#349783sternenseemann merged 1 commit intoNixOS:masterfrom
utillinux alias until node2nix is phased out#349783Conversation
|
(ping @AndersonTorres) |
let's hope NixOS/nixpkgs#349783 merge fast Signed-off-by: misilelab <misileminecord@gmail.com>
|
The whole variable should be removed Should also be fixed upstream too @svanderburg https://github.com/svanderburg/node2nix/blob/master/nix/node-env.nix#L7 |
|
This pr might also be reverted by node2nix like what happened in #319134 (comment) https://github.com/orgs/nix-community/discussions/1523 |
|
@AndersonTorres revert removing this alias and add # keep to it until its fixed upstream and a new ver is released |
67a51a7 to
a1e3838
Compare
The code generated by `node2nix` checks that `pkgs.utillinux` exist and uses it over `pkgs.util-linux`. Replacing the alias by a `throw`, as was done in commit a9e1f4e, makes packages generated using `node2nix` fail. This removes the alias removal until `node2nix` has been phased out, which is a work in progress started in NixOS#229475.
a1e3838 to
e1a23ee
Compare
util-linux instead of utillinux in node-env.nixutillinux alias until node2nix is phased out
|
@Artturin I've amended this PR to revert the alias removal until I have also submitted svanderburg/node2nix#336 so that |
|
We should probably just apply the patch to our |
|
Yeah I started on that, but we also need another patch to get rid of |
|
Perhaps it would be better to simply eliminate the remaining few in‐tree uses, since my experience the last time we had to test a patch was that it was very hard to even package anything modern with it at this point. |
|
Probably takes 15min to make a patch… much easier. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
|
This breaks my
|
This fixes that |
Apparently I need more sleep. I read the diff backwards |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Set `nixpkgs` to follow `nixpkgs-unstable` instead of `nixos-unstable` due to nix-community/home-manager#5991, caused by NixOS/nixpkgs@a9e1f4e reverted by NixOS/nixpkgs#349783 Should eventually be fixed in home-manager itself. Also pointed scientific-fhs to my fork: * new Julia versions * work around olynch/scientific-fhs#20
Set `nixpkgs` to follow `nixpkgs-unstable` instead of `nixos-unstable` due to nix-community/home-manager#5991, caused by NixOS/nixpkgs@a9e1f4e reverted by NixOS/nixpkgs#349783 Should eventually be fixed in home-manager itself. Also pointed `scientific-fhs` to my fork: * new Julia versions * work around olynch/scientific-fhs#20 Everything caused because I need this pull request catppuccin/nix#358 for KDE theming.
Theutil-linuxalias toutillinuxhas been replaced by athrowin commit a9e1f4e. The check innode-env.nixmust be reversed, it was previously a no-op (because of the alias) but will now lead to a failure as it will select theutillinuxthrow over theutil-linuxpackage.Also, tidy things up by using theutil-linuxvariable name instead of the olderutillinux.The code generated by
node2nixchecks thatpkgs.utillinuxexist and uses it overpkgs.util-linux. Replacing the alias by athrow, as was done in commit a9e1f4e, makes packages generated usingnode2nixfail.This removes the alias removal until
node2nixhas been phased out, which is a work in progress started in #229475.This PR fixes the build process of packages such as "emojione" but doesn't cause them to be rebuilt (so no "staging" merge), it prevents them from failing the build, which would happen without this change.
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.