Skip to content

neovim: expose vimPackage#348740

Merged
teto merged 1 commit intoNixOS:masterfrom
teto:teto/neovim-expose-vimPackage
Oct 15, 2024
Merged

neovim: expose vimPackage#348740
teto merged 1 commit intoNixOS:masterfrom
teto:teto/neovim-expose-vimPackage

Conversation

@teto
Copy link
Copy Markdown
Member

@teto teto commented Oct 15, 2024

it is relatively cumbersome to generate the vim package from the list of plugins so expose it so users can generate their own packpathdirs for an unwrapped neovim. I've tested this change with an upcoming home-manager change that makes neovim configuration more standard in the home-manager context

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

it is relatively cumbersome to generate the vim package from the list of plugins so expose it so users can generate their own packpathdirs for an unwrapped neovim. I've tested this change with an upcoming home-manager change that makes neovim configuration more standard in the home-manager context
@teto teto force-pushed the teto/neovim-expose-vimPackage branch from 174a06f to 2f4291a Compare October 15, 2024 12:08
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 15, 2024
@teto
Copy link
Copy Markdown
Member Author

teto commented Oct 15, 2024

Result of nixpkgs-review pr 348740 run on x86_64-linux 1

8 packages built:
  • gnvim
  • lunarvim
  • neovide
  • neovim-qt
  • neovim-remote
  • neovim-remote.dist
  • nvimpager
  • vim-startuptime

@teto
Copy link
Copy Markdown
Member Author

teto commented Oct 15, 2024

Merging because it fixes a small bug with null neovimRcContent

@teto teto merged commit b024224 into NixOS:master Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: vim Advanced text editor 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant