ci/request-reviews: fix headRef to point to the PR head#348004
Merged
philiptaron merged 1 commit intoNixOS:masterfrom Oct 11, 2024
Merged
ci/request-reviews: fix headRef to point to the PR head#348004philiptaron merged 1 commit intoNixOS:masterfrom
philiptaron merged 1 commit intoNixOS:masterfrom
Conversation
Previously, headRef points to the master branch of Nixpkgs, which
basically means no code owner review will be requested.
The problem can be verified using the following command.
$ DRY_MODE=1 ./ci/request-reviews/request-reviews.sh NixOS/nixpkgs 347973 ci/OWNERS
[...]
This PR touches 0 files
Requesting reviews from: {
"reviewers": []
}
[...]
Additionally, the comment about conflicts is removed thanks to the
unambiguous way of specifying ref.
philiptaron
approved these changes
Oct 11, 2024
Contributor
philiptaron
left a comment
philiptaron
left a comment
There was a problem hiding this comment.
Looks good to me. Silvan?
Contributor
Author
|
The fact that the |
Contributor
I like it -- it's like a quine! |
Member
|
Whut, I thought I used This is a good example to show why just testing with PRs is not enough.. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, headRef points to the master branch of Nixpkgs, which basically means no code owner review will be requested.
The problem can be verified using the following command.
Additionally, the comment about conflicts is removed thanks to the unambiguous way of specifying ref.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.