aspellDicts: add more dictionaries and some documentation

[oxij]

Motivation for this change

Jargon files.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
• Fits CONTRIBUTING.md.

---

[grahamc]

this redirects

[oxij]

this redirects

Fixed, I hope.

[grahamc]

@GrahamcOfBorg eval

[FRidh]

In both cases you set phases, why? Should this be improved in buildDict?

[oxij]

In both cases you set `phases`, why? Should this be improved in `buildDict`?

s/you/the author/ I wondered myself, but now it seems that it is by design. `preBuild` simply defines a bunch of functions, `buildPhase`s and `installPhases`s are different for different derivations, other default phases would either fail or are useless. But its true I can just move it to `buildDict`. Done. Also made another trivial change.

[FRidh]

We should not be using propagatedUserEnvPackages

[FRidh]

and aspell itself?

[FRidh]

This only considers the method where dicts are installed separate from aspell, and not aspellWithDicts. Perhaps there is a better place for this comment? Otherwise, it's good to have the explanation!

[FRidh]

Why are these needed? Should it not detect them?

[FRidh]

Quotes are not needed, and until the policy changes, they should not be included either.

[7c6f434c]

That's super annoying when upgrading a literal URL to a ${version} or ${name} one. Has this policy finally been written down somewhere?

[FRidh]

How about creating instead a src that can be consumed by the old buildDict? Any reason for not doing that?

[FRidh]

Any motivation for changing the name?

[oxij]

We should not be using `propagatedUserEnvPackages`

Any suggestions with what to replace it with? You should have `en_US` in the profile when installing `en_US-science`.

and aspell itself?

Fixed.

This only considers the method where dicts are installed separate from aspell, and not `aspellWithDicts`. Perhaps there is a better place for this comment? Otherwise, it's good to have the explanation!

The problem with `aspellWithDicts` is that it does `--set ASPELL_CONF` which breaks the above explanation. You would need to implement `aspellWithDictsAndConfig` to make this work. This is outside of scope of this PR.

Why are these needed? Should it not detect them?

They are "extra", opt-in.

Quotes are not needed, and until the policy changes, they should not be included either.

Official source on that claim? I'm motivated by #27809.

How about creating instead a `src` that can be consumed by the old `buildDict? Any reason for not doing that?

Pack files into an archive just to unpack them at the next beta-reduction? Seems crazy to me.

Any motivation for changing the name?

Right. Fixed.

[oxij]

Well whatever, the last patch has gone to SLNOS.

To make my position clear: I see no policy behind #27809. What I see is somebody making a huge change to nixpkgs that goes backwards and you merging it without discussion.

[FRidh]

Any suggestions with what to replace it with? You should have en_US in the
profile when installing en_US-science.

The closest would be aspellWithDicts, for installing individual packages there is nothing else.

The problem with aspellWithDicts is that it does --set ASPELL_CONF which breaks the above explanation.

See #34856.

You would need to implement aspellWithDictsAndConfig to make this work. This is outside of scope of this PR.

Agreed.

[oxij]

The closest would be `aspellWithDicts`, for installing individual packages there is nothing else.

Right. But if I removed the propagation now it would break plain `systemPackages` installs. Unless you put a check into `systemPackages` that rejects dictionaries I think the current impl is the correct one.

> The problem with `aspellWithDicts` is that it does `--set ASPELL_CONF` which breaks the above explanation. See #34856.

Looks ok to me, needs extensive testing. I propose we merge this first as it is well-tested (a whole year of fermentation in SLNOS) and makes things strictly better. You can always change the docstrings later when `aspellWithDicts` becomes awesome.

[7c6f434c]

OK, looks like this version is pure addition.