Skip to content

OWNERS: reference the ACME team directly#347832

Merged
infinisil merged 1 commit intoNixOS:masterfrom
emilazy:push-wpqzmxpntkpo
Oct 11, 2024
Merged

OWNERS: reference the ACME team directly#347832
infinisil merged 1 commit intoNixOS:masterfrom
emilazy:push-wpqzmxpntkpo

Conversation

@emilazy
Copy link
Member

@emilazy emilazy commented Oct 11, 2024

We can finally stop leaving @m1cr0man out thanks to #347610 🎉

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

We can finally stop leaving @m1cr0man out thanks to
<NixOS#347610> 🎉
@emilazy emilazy requested a review from a team October 11, 2024 01:47
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@infinisil infinisil merged commit bac526a into NixOS:master Oct 11, 2024
@emilazy emilazy deleted the push-wpqzmxpntkpo branch October 11, 2024 01:56
@m1cr0man
Copy link
Contributor

Thanks. It was annoying missing random acme related PRa 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants