Skip to content

workflows/codeowners: Cache codeowner validator build#347789

Merged
philiptaron merged 1 commit intoNixOS:masterfrom
tweag:codeowners-cache
Oct 12, 2024
Merged

workflows/codeowners: Cache codeowner validator build#347789
philiptaron merged 1 commit intoNixOS:masterfrom
tweag:codeowners-cache

Conversation

@infinisil
Copy link
Member

The codeowner-validator build declared in ci/codeowners-validator was not cached before and needed to be built for every PR, which is slow and wasteful: https://github.com/NixOS/nixpkgs/actions/runs/11280533037/job/31373720922

This is hard to test, but I'm using the exact same code as in e.g. basic-eval.yml, so it should work.


This work is sponsored by Antithesis

Add a 👍 reaction to pull requests you find important.

The codeowner-validator build declared in ci/codeowners-validator was
not cached before and needed to be built for every PR, which is slow and
wasteful: https://github.com/NixOS/nixpkgs/actions/runs/11280533037/job/31373720922
@github-actions github-actions bot added the 6.topic: policy discussion Discuss policies to work in and around Nixpkgs label Oct 10, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Oct 10, 2024
@infinisil infinisil requested a review from philiptaron October 12, 2024 02:00
@philiptaron philiptaron merged commit 46796b0 into NixOS:master Oct 12, 2024
@infinisil infinisil deleted the codeowners-cache branch October 12, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: policy discussion Discuss policies to work in and around Nixpkgs 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants