Skip to content

workflows/codeowners: Dry mode for now #347538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ambroisie merged 1 commit into from
Oct 9, 2024
Merged

workflows/codeowners: Dry mode for now #347538

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions .github/workflows/codeowners.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,12 @@ on:
env:
# TODO: Once confirmed that this works by seeing that the action would request
# reviews from the same people (or refuse for wrong base branches),
# move all entries from CODEOWNERS to OWNERS and change this value here
# OWNERS_FILE: .github/OWNERS
# move all entries from CODEOWNERS to OWNERS, remove these two lines and uncomment the ones below
OWNERS_FILE: .github/CODEOWNERS
# Also remove this
DRY_MODE: 1
# OWNERS_FILE: .github/OWNERS
# # Don't do anything on draft PRs
# DRY_MODE: ${{ github.event.pull_request.draft && '1' || '' }}

jobs:
# Check that code owners is valid
Expand Down Expand Up @@ -84,5 +85,3 @@ jobs:
run: result/bin/request-reviews.sh ${{ github.repository }} ${{ github.event.number }} "$OWNERS_FILE"
env:
GH_TOKEN: ${{ steps.app-token.outputs.token }}
# Don't do anything on draft PRs
DRY_MODE: ${{ github.event.pull_request.draft && '1' || '' }}