playwright-driver: fix eval on Nix 2.3#347114
Conversation
|
In this case we can probably make an exception, but eventually I don't think we should hold back using newer features if they benefit in nixpkgs. |
It's shocking how few new features are accidentally used -- the backwards compatibility is quite good, massive kudos to the Nix and Lix teams for this. The last PR of this sort was #329212 in July, and just like this one, was trivial to spot and remediate. The day will obviously come when |
6a9b27e to
72c938e
Compare
phaer
left a comment
There was a problem hiding this comment.
Thanks for catching & fixing :)
Motivation for changes
Fix evaluation on
nixVersions.minimum(Nix 2.3) so thatnixpkgs-vetis able to work on all versions of Nix that are supported in nixpkgs.This was detected with
nixpkgs-vet's automated update: NixOS/nixpkgs-vet#114Description of changes
Nix 2.3 doesn't support the
./${name}.nixsyntax that #298944 uses. Instead, it uses the clunkier./. + "/${name}.nix"syntax.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)