lowdown: disable sandbox on x86_64-darwin #346933
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 tasks
ofborg
bot
added
10.rebuild-darwin: 101-500
10.rebuild-linux: 0
13 tasks
reckenrode
force-pushed
the
push-ormxsrlloonl
branch
from
cda0a13 to
de8f2d2
Compare
SuperSandro2000
approved these changes
Oct 7, 2024
wegank
added
the
12.approvals: 1
|
If you’re happy with my approach, then I’d personally prefer it over this PR. I just didn’t want to rush a self‐merge, though it does already have an approval. I don’t mind this PR as a stop‐gap, either, since it’s already doing the bad thing on |
|
Since you got approvals for your approach, I went ahead and committed it. |
wrbbz
pushed a commit
to wrbbz/nixpkgs
that referenced
this pull request
Oct 9, 2024
This is a program written in a memory‐unsafe language that processes potentially‐untrusted user input. We shouldn’t disable upstream’s sandboxing mechanisms for all downstream consumers without good reason. Although the sandbox API is officially marked as deprecated, it is used as the basis for the supported App Sandbox and it is extremely unlikely to ever be removed as it is used extensively throughout the OS for service hardening and by third parties like the Chrome sandbox. Nix itself uses it to sandbox builds, and its lack of support for nesting is why this caused problems in the first place. Instead, introduce a `lowdown-unsandboxed` package that can be used in the `nativeBuildInputs` of Nix builds, while keeping the sandboxed version of the program for general use. The name might not be ideal, as it remains identical to `lowdown` on non‐Darwin platforms, but I couldn’t think of a better one. See: NixOS#125004 Closes: NixOS#346933
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #346043, lowdown will also try to use the sandbox on x86_64-darwin, which won’t work. It fixes the following error in
installCheckPhase.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.