linux: mark <6.12 with Rust as broken, assert on <6.7 with Rust#346648
Merged
Ma27 merged 1 commit intoNixOS:masterfrom Oct 12, 2024
Merged
linux: mark <6.12 with Rust as broken, assert on <6.7 with Rust#346648Ma27 merged 1 commit intoNixOS:masterfrom
Ma27 merged 1 commit intoNixOS:masterfrom
Conversation
Linux 6.7 is the oldest kernel with Rust support, so the config part should fail hard if 6.6 or older requests the Rust feature. Until now this was silently ignored[1]. It turned out that Rust for Linux 6.11 or older fails for unknown reasons[2]. We decided to not bother since it's not a longterm kernel and 6.12 seems fine again. As a result, marking this as broken. [1] NixOS#345534 (comment) [2] NixOS#345534 (comment)
ofborg
bot
added
10.rebuild-darwin: 0
Member
Author
Contributor
|
Seems fine |
alyssais
approved these changes
Oct 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
Note: I think it's more appropriate to fail with a custom message for kernels <6.7 with Rust enabled, so I didn't use
meta.brokenhere.Linux 6.7 is the oldest kernel with Rust support, so the config part should fail hard if 6.6 or older requests the Rust feature. Until now this was silently ignored[1].
It turned out that Rust for Linux 6.11 or older fails for unknown reasons[2]. We decided to not bother since it's not a longterm kernel and 6.12 seems fine again. As a result, marking this as broken.
[1] #345534 (comment)
[2] #345534 (comment)
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.