Skip to content

xen: fix seabios path#345172

Closed
CertainLach wants to merge 1 commit intoNixOS:masterfrom
CertainLach:xen/seabios
Closed

xen: fix seabios path#345172
CertainLach wants to merge 1 commit intoNixOS:masterfrom
CertainLach:xen/seabios

Conversation

@CertainLach
Copy link
Member

@CertainLach CertainLach commented Sep 28, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: xen-project Issues and PRs related to the Xen Project Hypervisor. label Sep 28, 2024
@SigmaSquadron
Copy link
Contributor

Ideally we'd have something similar to OVMF.firmware. @AndersonTorres as the SeaBIOS maintainer, would you be opposed to a passthru.firmware attribute that pointed to ${finalAttrs.finalPackage}/share/seabios/${firmware} where firmware is Csm16.bin by default?

@SigmaSquadron
Copy link
Contributor

SigmaSquadron commented Sep 28, 2024

Also, I'm assuming #341429 will need to override seabios to point to qubes-seabios? (which will have the same passthru.firmware but that points to the Qubes-specific executable.)

@CertainLach
Copy link
Member Author

Yes, that's right. qubes-seabios is packaged in qubes-packages PR, wanted firmware filename is "bios-256k.bin"

@SigmaSquadron
Copy link
Contributor

Yes, that's right. qubes-seabios is packaged in qubes-packages PR, wanted firmware filename is "bios-256k.bin"

Add something like this to qubes-seabios:

passthru.firmware = "${finalAttrs.finalPackage}/share/seabios/bios-256k.bin";

and once we get the firmware attr in the main seabios package, it'll Just Work™ and is cleaner than another override.

@ofborg ofborg bot requested a review from hehongbo September 28, 2024 20:32
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Sep 28, 2024
@AndersonTorres
Copy link
Member

To me, no problems. I am working on this:

#342692

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: xen-project Issues and PRs related to the Xen Project Hypervisor. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants