openssl_3_3: move cmake rm to correct phase#344139
Merged
emilazy merged 1 commit intoNixOS:staging-nextfrom Sep 24, 2024
Merged
openssl_3_3: move cmake rm to correct phase#344139emilazy merged 1 commit intoNixOS:staging-nextfrom
emilazy merged 1 commit intoNixOS:staging-nextfrom
Conversation
Signed-off-by: Markus Theil <theil.markus@gmail.com>
emilazy
approved these changes
Sep 24, 2024
Member
|
Thankfully we’re reverting the GCC update so we’re rebuilding the world anyway 🫠 Should have tested more thoroughly but the builder died as I was trying Mumble, apologies. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
I messed things up in a cleanup commit of #343991. Cmake + pkg-config helpers get moved to -dev in the fixup phase. So remove the cmake part in post-fixup again.
@emilazy Sry for the garbage I produced in my last PR :(
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.