Skip to content

c3-lsp: init at 0.3.2#343801

Merged
mattpolzin merged 1 commit intoNixOS:masterfrom
arthsmn:c3-lsp
Oct 2, 2024
Merged

c3-lsp: init at 0.3.2#343801
mattpolzin merged 1 commit intoNixOS:masterfrom
arthsmn:c3-lsp

Conversation

@arthsmn
Copy link
Member

@arthsmn arthsmn commented Sep 22, 2024

Description of changes

Closes #343745

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Sep 22, 2024
@momeemt
Copy link
Member

momeemt commented Sep 24, 2024

Result of nixpkgs-review pr 343801 run on aarch64-darwin 1

1 package built:
  • c3-lsp

Copy link
Member

@momeemt momeemt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. LGTM

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 25, 2024
@BirdeeHub
Copy link
Contributor

Result of nixpkgs-review pr 343801 run on x86_64-linux 1

1 package built:
  • c3-lsp

@BirdeeHub
Copy link
Contributor

looks good to me! good use of sourceRoot to avoid all the vscode stuff.

@vssukharev
Copy link

Result of nixpkgs-review pr 343801 run on x86_64-linux 1

1 package built:
  • c3-lsp

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Oct 2, 2024
@mattpolzin
Copy link
Contributor

mattpolzin commented Oct 2, 2024

Result of nixpkgs-review pr 343801 run on x86_64-darwin 1

1 package built:
  • c3-lsp

Built & launched executable.

@mattpolzin mattpolzin merged commit ead8c92 into NixOS:master Oct 2, 2024
@arthsmn arthsmn deleted the c3-lsp branch October 3, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Package request: c3-lsp

6 participants