Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

podman-desktop: 0.12.0 -> 1.13.2 #343648

Merged
merged 6 commits into from
Oct 19, 2024
Merged

podman-desktop: 0.12.0 -> 1.13.2 #343648

merged 6 commits into from
Oct 19, 2024

Conversation

booxter
Copy link
Contributor

@booxter booxter commented Sep 22, 2024 •
edited
Loading

This also fixes a build failure on darwin due to read-only permissions on some Electron.app files, which apparently breaks electron-builder.

Closes: #343328

Description of changes

  • Bump the version to the latest release.
  • Sign the macos app with a hook.
  • Don't use desktopToDarwinBundle for Darwin.
  • Switched from yarn to pnpm.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from panda2134 September 22, 2024 05:48
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Sep 22, 2024
panda2134
panda2134 approved these changes Sep 22, 2024
View reviewed changes
Copy link
Contributor

@panda2134 panda2134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Sep 22, 2024
@booxter booxter force-pushed the podman-desktop branch 3 times, most recently from 4792951 to 05bff7c Compare September 26, 2024 01:48
@ofborg ofborg bot requested a review from panda2134 September 26, 2024 03:46
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 26, 2024
@booxter
Copy link
Contributor Author

booxter commented Sep 27, 2024

The passthru tests for linux fail with permission denied when building the Electron bundle too:

  ⨯ EACCES: permission denied, open '/build/source-patched/dist/linux-unpacked/podman-desktop'  failedTask=build stackTrace=Error: EACCES: permission denied, open '/build/source-patched/dist/linux-unpacked/podman-desktop'

I wonder if perhaps the "ugly hack" to fix it with chmod will have to be applied for all platforms.

@khaneliman
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 343648

x86_64-linux

❌ 1 package failed to build:
  • podman-desktop

@khaneliman
Copy link
Contributor

For some reason, it's also not detecting a darwin rebuild.

@khaneliman
Copy link
Contributor 

   > mv: missing destination file operand after '/nix/store/mg2p3sanr09glbkc8r5l4yin3m810g77-podman-desktop-1.12.0/Applications'

x86-darwin ofborg error

@booxter
Copy link
Contributor Author

booxter commented Oct 3, 2024

Fixed mac x86 build (the directory is just dist/mac in this case). Applying chmod hack for linux, since it looks like the error is otherwise identical to darwin.

@khaneliman
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 343648

x86_64-linux

❌ 1 package failed to build:
  • podman-desktop

aarch64-linux

❌ 1 package failed to build:
  • podman-desktop

x86_64-darwin

✅ 1 package built:
  • podman-desktop

aarch64-darwin

✅ 1 package built:
  • podman-desktop

@booxter
Copy link
Contributor Author

booxter commented Oct 4, 2024

Both linux builds fail with:

Error: getaddrinfo EAI_AGAIN registry.npmjs.org
    at GetAddrInfoReqWrap.onlookupall [as oncomplete] (node:dns:120:26)
Emitted 'error' event on ClientRequest instance at:
    at emitErrorEvent (node:_http_client:108:11)
    at TLSSocket.socketErrorListener (node:_http_client:511:5)
    at TLSSocket.emit (node:events:519:28)
    at emitErrorNT (node:internal/streams/destroy:169:8)
    at emitErrorCloseNT (node:internal/streams/destroy:128:3)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
  errno: -3001,
  code: 'EAI_AGAIN',
  syscall: 'getaddrinfo',
  hostname: 'registry.npmjs.org'
}

which I think is a sign that networking is sandboxed for these builders (but not for macos); so they probably fail to fetch something from npmjs registry to build the offline deps bundle. I am not sure how this is supposed to be tackled on packaging side. Any advice is welcome.

@booxter
Copy link
Contributor Author

booxter commented Oct 4, 2024

I don't understand how any package relying on prefetch-yarn-deps could ever build without DNS / fetching from NPM. Isn't it the whole point of the derivation - to fetch packages from registry (and then make sure that SHA is as expected)?

@booxter
Copy link
Contributor Author

booxter commented Oct 15, 2024

It's currently failing locally with

cp: cannot stat '/nix/store/8kfqm2hacl3s6zydjayw3lhk6p9gcx7v-electron-unwrapped-32.1.2/libexec/electron/Electron.app': No such file or directory

I will need to attend to this, though I still don't understand why DNS fails in ofborg. When I have a linux fix, we'll see if ofborg is any happier then.

@booxter
podman-desktop: 0.12.0 -> 1.12.0
1b89990 
This also fixes a build failure on darwin due to read-only permissions
on some Electron.app files, which apparently breaks electron-builder.

Closes: NixOS#343328
@booxter booxter changed the title podman-desktop: 0.12.0 -> 1.12.0 podman-desktop: 0.12.0 -> 1.13.2 Oct 16, 2024
@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Oct 16, 2024
@booxter
podman-desktop: 0.12.0 -> 1.13.2
d4e06dd
@booxter
maintainers: add booxter
9f7fc2b 
Also, add booxter to maintainers for podman-desktop.
@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Oct 16, 2024
@khaneliman
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 343648

x86_64-linux

✅ 1 package built:
  • podman-desktop

aarch64-linux

✅ 1 package built:
  • podman-desktop

@khaneliman
Copy link
Contributor

Detecting no rebuild for darwin, for some reason. Going to manually build.

@khaneliman
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 343648

x86_64-darwin

✅ 1 package built:
  • podman-desktop

aarch64-darwin

✅ 1 package built:
  • podman-desktop

khaneliman
khaneliman approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@khaneliman khaneliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
image

@Artturin Artturin merged commit 8017b96 into NixOS:master Oct 19, 2024
30 checks passed
@Scrumplex Scrumplex mentioned this pull request Oct 19, 2024
Merged
13 tasks
@gepbird gepbird mentioned this pull request Oct 19, 2024
Closed
1 task
@kachick kachick mentioned this pull request Oct 20, 2024
Closed
@kachick kachick mentioned this pull request Dec 24, 2024
Closed
@booxter booxter mentioned this pull request Jan 28, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khaneliman khaneliman khaneliman approved these changes

@panda2134 panda2134 Awaiting requested review from panda2134

Assignees
No one assigned
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build failure: podman-desktop @0.12.0 on Darwin
5 participants
@booxter @khaneliman @panda2134 @wegank @Artturin