Skip to content

nix-serve: pin nix to nixVersions.nix_2_18 (previous stable) due to breaking changes#342716

Merged
Aleksanaa merged 1 commit intoNixOS:masterfrom
fabianhjr:nix-serve-pin-nix
Sep 18, 2024
Merged

nix-serve: pin nix to nixVersions.nix_2_18 (previous stable) due to breaking changes#342716
Aleksanaa merged 1 commit intoNixOS:masterfrom
fabianhjr:nix-serve-pin-nix

Conversation

@fabianhjr
Copy link
Member

Description of changes

Alternative for #342714

Fixes broken nixosTests.nix-serve after

#335342

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@fabianhjr
Copy link
Member Author

@ofborg test nix-serve

@fabianhjr fabianhjr requested a review from Aleksanaa September 18, 2024 04:25
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Sep 18, 2024
@Aleksanaa Aleksanaa marked this pull request as ready for review September 18, 2024 05:56
@Aleksanaa Aleksanaa merged commit 3385895 into NixOS:master Sep 18, 2024
@fabianhjr fabianhjr deleted the nix-serve-pin-nix branch September 18, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants